Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fmt, cleanup, fix references #4442

Merged
merged 10 commits into from
Mar 12, 2024
Merged

chore: fmt, cleanup, fix references #4442

merged 10 commits into from
Mar 12, 2024

Conversation

dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Jan 30, 2024

for https://github.com/ComposableFi/restaking-spec/issues/1#issuecomment-1923391405

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

Copy link

github-actions bot commented Feb 4, 2024

stale-pr

@github-actions github-actions bot added Stale-item bot: Stale PRs and issues handling #owned:terraform and removed Stale-item bot: Stale PRs and issues handling #owned:terraform labels Feb 4, 2024
@github-actions github-actions bot added the Stale-item bot: Stale PRs and issues handling #owned:terraform label Feb 14, 2024
@ComposableFi ComposableFi deleted a comment from github-actions bot Feb 14, 2024
@dzmitry-lahoda
Copy link
Contributor Author

in progress

@github-actions github-actions bot removed the Stale-item bot: Stale PRs and issues handling #owned:terraform label Feb 15, 2024
Copy link

stale-pr

@github-actions github-actions bot added the Stale-item bot: Stale PRs and issues handling #owned:terraform label Feb 20, 2024
Copy link

close-pr

@github-actions github-actions bot closed this Feb 25, 2024
@github-actions github-actions bot removed the Stale-item bot: Stale PRs and issues handling #owned:terraform label Mar 12, 2024
happy

happier 2x

fixed wording

clean up

happoer

fixes

happier

Update specification.md

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

Update and rename virtual-wallet.md to composable-account-abstraction.md

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

Update specification.md

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

Update specification.md

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

Update specification.md

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

Update specification.md

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

docs

graph

happy

happoer
@dzmitry-lahoda dzmitry-lahoda changed the title #wip #draft docs: tasks and cda arch chore: fmt, cleanup, fix references Mar 12, 2024
@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review March 12, 2024 10:43
@dzmitry-lahoda dzmitry-lahoda merged commit df7a8b8 into main Mar 12, 2024
23 checks passed
@dzmitry-lahoda dzmitry-lahoda deleted the dz/c/7 branch March 12, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant