cleanup some CI cruft

.github/workflows/check.yml

@@ -59,18 +59,14 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - run: |
-          /home/runner/.cargo/bin/rustup install nightly-2021-11-29
-          /home/runner/.cargo/bin/rustup target add --toolchain=nightly-2021-11-29 wasm32-unknown-unknown
-          /home/runner/.cargo/bin/rustup show
-          /home/runner/.cargo/bin/rustup override unset
           /home/runner/.cargo/bin/rustup show
       - name: Use Node.js 14.x
         uses: actions/setup-node@v2
         with:
           node-version: 14.x
       - name: Cargo fmt
         run: |
-          /home/runner/.cargo/bin/cargo +nightly-2021-11-29 fmt -- --check
+          /home/runner/.cargo/bin/cargo fmt -- --check
       - name: Hadolint
         env:
           HADOLINT_VERSION: v2.8.0
@@ -101,7 +97,7 @@ jobs:
           exit $total_exit_code
       - name: Cargo clippy
         run: |
-          SKIP_WASM_BUILD=1 /home/runner/.cargo/bin/cargo +nightly-2021-11-29 clippy -- -D warnings
+          SKIP_WASM_BUILD=1 /home/runner/.cargo/bin/cargo clippy --workspace -- -D warnings
       - name: Cargo udeps
         env:
           UDEPS_VERSION: v0.1.24
@@ -110,8 +106,8 @@ jobs:
           tar xzf "cargo-udeps-${UDEPS_VERSION}-x86_64-unknown-linux-gnu.tar.gz"
           cp "cargo-udeps-${UDEPS_VERSION}-x86_64-unknown-linux-gnu/cargo-udeps" ~/.cargo/bin/
           rm -r "cargo-udeps-${UDEPS_VERSION}-x86_64-unknown-linux-gnu.tar.gz" "cargo-udeps-${UDEPS_VERSION}-x86_64-unknown-linux-gnu"
-          /home/runner/.cargo/bin/cargo +nightly-2021-11-29 udeps --version
-          SKIP_WASM_BUILD=1 /home/runner/.cargo/bin/cargo +nightly-2021-11-29 udeps --workspace --all-features
+          /home/runner/.cargo/bin/cargo udeps --version
+          SKIP_WASM_BUILD=1 /home/runner/.cargo/bin/cargo udeps --workspace --all-features
         continue-on-error: true # Often this turns gives false positives, due to the different ways that Substrate uses features.  
   test:
     name: Unit Test
@@ -126,9 +122,7 @@ jobs:
         run: curl -LsSf https://github.com/taiki-e/cargo-llvm-cov/releases/latest/download/cargo-llvm-cov-x86_64-unknown-linux-gnu.tar.gz | tar xzf - -C ~/.cargo/bin
       - name: Run Test (with coverage)
         run: |
-          /home/runner/.cargo/bin/rustup install nightly-2021-11-29
-          /home/runner/.cargo/bin/rustup component add llvm-tools-preview --toolchain=nightly-2021-11-29
-          SKIP_WASM_BUILD=1 /home/runner/.cargo/bin/cargo +nightly-2021-11-29 llvm-cov --workspace --lcov --output-path lcov.info
+          SKIP_WASM_BUILD=1 /home/runner/.cargo/bin/cargo llvm-cov --workspace --lcov --output-path lcov.info
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v1
         with:

.gitignore

@@ -30,3 +30,4 @@ scripts/polkadot-launch/*.log
 
 target
 .env
+**/.yarn/

frame/composable-support/src/validation.rs

@@ -55,8 +55,7 @@ impl<T: Validate<U> + Validate<V>, U, V> Validate<(U, V)> for T {
 
 impl<T: codec::Decode + Validate<(U, V)>, U, V> codec::Decode for Validated<T, (U, V)> {
 	fn decode<I: codec::Input>(input: &mut I) -> Result<Self, codec::Error> {
-		let value = Validate::validate(T::decode(input)?)
-			.map_err(|desc| Into::<codec::Error>::into(desc))?;
+		let value = Validate::validate(T::decode(input)?).map_err(Into::<codec::Error>::into)?;
 		Ok(Validated { value, _marker: PhantomData })
 	}
 	fn skip<I: codec::Input>(input: &mut I) -> Result<(), codec::Error> {

integration-tests/simnode/src/events.rs

@@ -1,4 +1,5 @@
 /// Concrete event type for verbose event asserts in tests.
+#[allow(clippy::large_enum_variant)]
 #[derive(derive_more::From)]
 pub enum AllRuntimeEvents {
 	/// Picassoo runtime events

rust-toolchain.toml

@@ -0,0 +1,5 @@
+[toolchain]
+channel = "nightly-2021-11-29"
+components = [ "rustfmt", "rustc", "rust-std", "cargo", "clippy", "llvm-tools-preview"]
+targets = [ "wasm32-unknown-unknown" ]
+profile = "minimal"