Oracle

[scruffy-dev]

Just adding some checks and clean up slowly no need to merge anytime soon, code will stay isolated to this pallet

[flipchan]

Checking this

[flipchan]

code looks good, conserns on the request_price function:

     #[pallet::weight(10_000)]
     pub fn request_price(origin: OriginFor<T>, asset_id: u64) -> DispatchResultWithPostInfo {                         
         //TODO talk about the security and if this should be protected                                                
         let who = ensure_signed(origin)?;
         Self::do_request_price(&who, asset_id)?;
         Ok(().into())
     }

[flipchan]

nice integration with offchain workers

[scruffy-dev]

code looks good, conserns on the request_price function:

     #[pallet::weight(10_000)]
     pub fn request_price(origin: OriginFor<T>, asset_id: u64) -> DispatchResultWithPostInfo {                         
         //TODO talk about the security and if this should be protected                                                
         let who = ensure_signed(origin)?;
         Self::do_request_price(&who, asset_id)?;
         Ok(().into())
     }

Agreed needs to be a larger conversation on how we set parameters, there exists a world where the params allow this to be safe, and a world where it does not, anyways, we can always wrap in ensure_root but that would be a worst case scenerio