-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include local_workspace config directory in the distribution #100
Conversation
PR Review 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to d5a2747 in 1 minute and 5 seconds
More details
- Looked at
19
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_8E42J2wtjCUM5xFg
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
⌛ 2 days left in your free trial, upgrade for $20/seat/month or contact us.
@@ -49,4 +49,10 @@ | |||
"pyyaml>=6.0.1", | |||
], | |||
include_package_data=True, | |||
package_data={ | |||
"composio": [ | |||
"local_tools/local_workspace/config/*.yaml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure that the paths specified in package_data
accurately reflect the actual directory structure and file types in the repository. If the paths or file types are incorrect, the files will not be included in the distribution as expected.
PR Type
enhancement
Description
setup.py
to include thelocal_tools/local_workspace/config
directory in the distribution.Changes walkthrough 📝
setup.py
Include local workspace config directory in package data
setup.py
package_data
to includelocal_tools/local_workspace/config/*.yaml
andlocal_tools/local_workspace/config/commands/*.sh
in the distribution.Summary:
This PR adds the
local_workspace/config/commands
directory to thecomposio
package distribution, including necessary YAML and shell script files.Key points:
local_workspace/config/commands
directory tocomposio
package distribution.setup.py
to include YAML and shell script files from the new directory.Generated with ❤️ by ellipsis.dev