feat: sdr kit agents #1028
feat: sdr kit agents #1028
Conversation
Prat011
requested review from
angrybayblade and
tushar-composio
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update introduces two new agents: the Market Research Agent and the Meeting Agent. The Market Research Agent aids indie hackers by providing niche ideas through comprehensive market analysis, while the Meeting Agent facilitates meeting creation and analysis using Google Meet and Zoom. Both agents leverage the Composio framework and various language models for enhanced functionality. Additionally, minor corrections were made to existing README files to ensure accurate file paths and descriptions. Changes
🔗 Related PRs
InstructionsEmoji Descriptions:
Interact with the Bot:
Execute a command using the format:
Available Commands:
Tips for Using @bot Effectively:
Need More Help?📚 Visit our documentation for detailed guides on using Entelligence.AI. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 38635b0 in 1 minute and 7 seconds
More details
- Looked at
373lines of code in13files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. python/examples/advanced_agents/sales_kit/meeting_agent/readme.md:3
- Draft comment:
The description mentions creating market research reports, which seems incorrect for a meeting agent. Update the description to accurately reflect the meeting agent's functionality. - Reason this comment was not posted:
Comment did not seem useful.
2. python/examples/advanced_agents/sales_kit/market_research_agent/main.py:50
-
Draft comment:
Remove this duplicate initialization - it's identical to the one above. -
FunctionCallingAgentWorker initialization (main.py)
-
Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_Jdq5p6PQDmIqKNW3
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| ).as_agent() | ||
|
|
||
|
|
||
| agent = FunctionCallingAgentWorker( |
There was a problem hiding this comment.
Duplicate initialization of agent. Remove the redundant block to avoid confusion and potential errors.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on fd7a384 in 30 seconds
More details
- Looked at
69lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js/examples/market_research_agent/readme..md:1
- Draft comment:
The filenamereadme..mdcontains a typo with an extra dot. It should bereadme.md. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_hWT6MoCKfuIEEmmS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
![entelligence-ai-pr-reviews[bot]](https://avatars.githubusercontent.com/in/932812?s=60&v=4){kind=small}
| console.log("Tools:", tools); | ||
| //console.log("Prompt:", prompt); | ||
|
|
||
| const additional = `You are a market research agent that finds niche ideas that can be built and marketed. | ||
| const additional = ` | ||
| You are a market research agent that finds niche ideas that can be built and marketed. | ||
| Your users are primarily indie hackers who want to build something new and are looking for ideas. The input will | ||
| be a domain or a category and your job is to research extensively and find ideas that can be marketed. | ||
| Also write the content to market a tool built with this idea. It should be very very specific and not too long.`; | ||
| Write this content in a google doc, create a google doc before writing in it. | ||
| I want you to show the following content: | ||
| - Data Collection and Aggregation - Show data supporting a trend | ||
| - Sentiment Analysis - Show customer sentiment on the topic | ||
| - Trend Forecasting | ||
| - Competitor Analysis | ||
| - Competitor Benchmarking | ||
| - Idea Validation`; |
There was a problem hiding this comment.
Optional Google Doc Creation for Flexibility
The recent change introduces a requirement to write content in a Google Doc, which may not be feasible for all users or environments. This could lead to issues in scenarios where Google services are inaccessible or not preferred. To enhance flexibility and usability, consider making the Google Doc creation optional or configurable. This allows users to choose their preferred method of content output, ensuring broader applicability and user satisfaction.
Actionable Suggestions:
- Introduce a configuration option to toggle Google Doc creation.
- Provide alternative output methods, such as plain text or local file storage.
- Ensure that the default behavior is well-documented to guide users in configuring their preferred settings.
By implementing these changes, you can cater to a wider audience and avoid potential limitations or dependencies. 🌐
🔧 Suggested Code Diff:
- Write this content in a google doc, create a google doc before writing in it.
+ // Optionally write this content in a Google Doc if configured
+ if (config.useGoogleDoc) {
+ // Code to create and write to Google Doc
+ } else {
+ // Alternative output method
+ }📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| console.log("Tools:", tools); | |
| //console.log("Prompt:", prompt); | |
| const additional = `You are a market research agent that finds niche ideas that can be built and marketed. | |
| const additional = ` | |
| You are a market research agent that finds niche ideas that can be built and marketed. | |
| Your users are primarily indie hackers who want to build something new and are looking for ideas. The input will | |
| be a domain or a category and your job is to research extensively and find ideas that can be marketed. | |
| Also write the content to market a tool built with this idea. It should be very very specific and not too long.`; | |
| Write this content in a google doc, create a google doc before writing in it. | |
| I want you to show the following content: | |
| - Data Collection and Aggregation - Show data supporting a trend | |
| - Sentiment Analysis - Show customer sentiment on the topic | |
| - Trend Forecasting | |
| - Competitor Analysis | |
| - Competitor Benchmarking | |
| - Idea Validation`; | |
| console.log("Tools:", tools); | |
| const additional = ` | |
| You are a market research agent that finds niche ideas that can be built and marketed. Your users are primarily indie hackers who want to build something new and are looking for ideas. The input will be a domain or a category and your job is to research extensively and find ideas that can be marketed. | |
| // Optionally write this content in a Google Doc if configured | |
| if (config.useGoogleDoc) { | |
| // Code to create and write to Google Doc | |
| } else { | |
| // Alternative output method, e.g., save to a local file or output as plain text | |
| } | |
| I want you to show the following content: | |
| - Data Collection and Aggregation - Show data supporting a trend | |
| - Sentiment Analysis - Show customer sentiment on the topic | |
| - Trend Forecasting | |
| - Competitor Analysis | |
| - Competitor Benchmarking | |
| `; | |
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 632e131 in 29 seconds
More details
- Looked at
9lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_AcxQbDZPoirgBMdW
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -0,0 +1,2 @@ | |||
| COMPOSIO_API_KEY=KEY | |||
| OPENAI_API_KEY=KEY | |||
There was a problem hiding this comment.
Add a newline at the end of the file for POSIX compliance.
|
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
There was a problem hiding this comment.
❌ Changes requested. Incremental review on cb28de6 in 47 seconds
More details
- Looked at
501lines of code in11files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. js/examples/conversational_agent/backend/server.py:31
- Draft comment:
Consider adding logging for missing environment variables to aid in debugging. - Reason this comment was not posted:
Confidence changes required:50%
The Python server code usesos.getenvto fetch environment variables, which is correct. However, it does not handle the case where the environment variables might not be set, except for raising an HTTPException. This is fine, but it could be improved by logging a more descriptive error message.
2. js/examples/conversational_agent/backend/server.py:10
- Draft comment:
Consider using thePORTenvironment variable in the Python server to maintain consistency with the Node.js server. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
3. js/examples/conversational_agent/package.json:10
- Draft comment:
Consider using thePORTenvironment variable in thestart:pythonscript to maintain consistency with the Node.js server. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_RrVUez9O0zJdhtc9
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
|
||
| app.get('/api/signed-url', async (req, res) => { | ||
| try { | ||
| const response = await fetch( |
There was a problem hiding this comment.
fetch is used but not imported. Consider importing it using node-fetch or another compatible library.
|
|
||
| #API route for getting Agent ID, used for public agents | ||
| @app.get("/api/getAgentId") | ||
| def get_unsigned_url(): |
There was a problem hiding this comment.
The function name get_unsigned_url is misleading. Consider renaming it to get_agent_id for clarity.
🔍 Review Summary
Purpose
Changes
New Features
Bug Fixes
Impact
Original Description
No existing description found
Important
Introduces Market Research and Meeting Agents, and fixes script paths in existing agents' documentation.
market_research_agent.meeting_agent.readme.md.crewai/readme.md.llamaindex/readme.md.This description was created by
for cb28de6. It will automatically update as commits are pushed.