feat: add plugin tests #1096
feat: add plugin tests #1096
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to cf4548c in 32 seconds
More details
- Looked at
68lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_CG7uX4Xy3xiluGET
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| "drafted. Please provide a value of type string.", | ||
| "title": "Thread Id", | ||
| # TODO: this seems wrong, why both type and anyof | ||
| "type": "string", |
There was a problem hiding this comment.
The use of both type and anyOf for thread_id is inconsistent. Consider removing the type key or ensure it aligns with the anyOf specification.
| "drafted. Please provide a value of type string.", | ||
| "title": "Thread Id", | ||
| # TODO: this seems wrong, why both type and anyof | ||
| "type": "string", |
There was a problem hiding this comment.
The redundant type definition here could be simplified. Since thread_id is an optional string parameter, we could either:
- Remove the
type: stringand keep only theanyOfdefinition, or - Use
type: ["string", "null"]instead
The current implementation with both type and anyOf is redundant and could cause confusion in schema validation.
| from composio import Action, App | ||
| from composio.client.enums.base import ActionData | ||
| from composio.tools.local.base import action | ||
| import composio_openai |
There was a problem hiding this comment.
Consider grouping related imports together and removing unused ones:
from composio import Action, App # Action is unused
from composio.client.enums.base import ActionData # ActionData is unused
from composio.tools.local.base import action
# Group plugin imports
import composio_openai
import composio_crewai # Unused
import composio_langchain # Unused
import composio_llamaindex # UnusedThis will make the imports cleaner and more maintainable.
Code Review SummaryThe PR adds valuable test coverage for input serialization in the
Suggestions for Improvement:
Overall, this is a good addition to the test suite that will help ensure consistent parameter handling across different runtime implementations. The code quality is good with room for minor improvements. |
![entelligence-ai-pr-reviews[bot]](https://avatars.githubusercontent.com/in/932812?s=60&v=4){kind=small}
| "title": "Message Body", | ||
| "type": "string", | ||
| }, | ||
| "thread_id": { | ||
| "description": "The ID of the thread to which the reply is to be " | ||
| "drafted. Please provide a value of type string.", | ||
| "title": "Thread Id", | ||
| # TODO: this seems wrong, why both type and anyof | ||
| "type": "string", | ||
| "anyOf": [ | ||
| {"type": "string"}, | ||
| {"type": "null"}, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
🤖 Bug Fix:
Redundant Schema Definition for 'thread_id'
The current schema definition for the 'thread_id' field uses both 'type' and 'anyOf', which is redundant and can lead to confusion in schema validation. To improve clarity and avoid potential validation errors, it's recommended to use only 'anyOf' if the intention is to allow both string and null values. This will streamline the schema and ensure consistent behavior.
🔧 Suggested Code Diff:
- "type": "string",
"anyOf": [
{"type": "string"},
{"type": "null"},
],📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| "title": "Message Body", | |
| "type": "string", | |
| }, | |
| "thread_id": { | |
| "description": "The ID of the thread to which the reply is to be " | |
| "drafted. Please provide a value of type string.", | |
| "title": "Thread Id", | |
| # TODO: this seems wrong, why both type and anyof | |
| "type": "string", | |
| "anyOf": [ | |
| {"type": "string"}, | |
| {"type": "null"}, | |
| ], | |
| }, | |
| { | |
| "title": "Message Body", | |
| "type": "string", | |
| }, | |
| "thread_id": { | |
| "description": "The ID of the thread to which the reply is to be drafted. Please provide a value of type string or null.", | |
| "title": "Thread Id", | |
| "anyOf": [ | |
| {"type": "string"}, | |
| {"type": "null"}, | |
| ], | |
| } |
tushar-composio
changed the title
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b3d0029 in 24 seconds
More details
- Looked at
34lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. python/composio/tools/local/codeanalysis/embedder.py:51
- Draft comment:
Consider the impact of moving the 'SentenceTransformer' import inside the 'init' method. This can reduce initial load time but may delay instantiation. - Reason this comment was not posted:
Confidence changes required:33%
The import statement for 'SentenceTransformer' was moved inside the 'init' method of the 'Embedding' class. This change is beneficial for reducing the initial load time and memory usage if the 'Embedding' class is not instantiated. However, it should be noted that this can lead to a slight delay when the class is first instantiated, as the import will occur at that time.
2. python/tests/test_tools/test_plugins.py:46
- Draft comment:
Remove 'type' when using 'anyOf' to avoid redundancy. Applicable to 'thread_id' and similar cases. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_b80AZGHzjVoSl00g
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| "drafted. Please provide a value of type string.", | ||
| "title": "Thread Id", | ||
| # TODO: this seems wrong, why both type and anyof | ||
| "type": "string", | ||
| "default": None, | ||
| "anyOf": [ | ||
| {"type": "string"}, | ||
| {"type": "null"}, | ||
| ], | ||
| }, | ||
| }, | ||
| "required": [ | ||
| "message_body", | ||
| ], | ||
| "title": "CreateDraftRequest", | ||
| "type": "object", | ||
| }, | ||
| }, | ||
| "type": "function", | ||
| }, |
There was a problem hiding this comment.
🤖 Bug Fix:
Redundant Type Definition in 'thread_id' Field
The current schema for the 'thread_id' field uses both 'type' and 'anyOf', which is redundant and can lead to confusion. The 'anyOf' construct already specifies that the field can be either a string or null, making the 'type' declaration unnecessary. Removing the 'type' field will simplify the schema and prevent potential validation issues. This change will ensure clarity and maintainability of the code. 🛠️
🔧 Suggested Code Diff:
- "type": "string",
"anyOf": [
{"type": "string"},
{"type": "null"},
],📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| "drafted. Please provide a value of type string.", | |
| "title": "Thread Id", | |
| # TODO: this seems wrong, why both type and anyof | |
| "type": "string", | |
| "default": None, | |
| "anyOf": [ | |
| {"type": "string"}, | |
| {"type": "null"}, | |
| ], | |
| }, | |
| }, | |
| "required": [ | |
| "message_body", | |
| ], | |
| "title": "CreateDraftRequest", | |
| "type": "object", | |
| }, | |
| }, | |
| "type": "function", | |
| }, | |
| { | |
| "thread_id": { | |
| "description": "The ID of the thread to which the reply is to be drafted. Please provide a value of type string.", | |
| "title": "Thread Id", | |
| "default": None, | |
| "anyOf": [ | |
| {"type": "string"}, | |
| {"type": "null"} | |
| ] | |
| } | |
| } |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ba782b7 in 14 seconds
More details
- Looked at
49lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. .github/workflows/common.yml:105
- Draft comment:
Consider moving the conditionif: matrix.python-version == '3.10'to the job level for consistency with other jobs. - Reason this comment was not posted:
Confidence changes required:50%
The addition of the plugin tests in the workflow is a good step, but the condition for running them is not consistent with the rest of the workflow. The condition should be placed on the job level, not the step level, for consistency and clarity.
2. python/tox.ini:124
- Draft comment:
The installation ofplugins/langchainis redundant here as it is already included in the[testenv:plugins]section. Consider removing it to avoid unnecessary installations. - Reason this comment was not posted:
Confidence changes required:50%
Thetox.inifile has a redundant installation ofplugins/langchainin the[testenv:test]section. This is unnecessary because the[testenv:plugins]section already handles plugin installations.
Workflow ID: wflow_PeG3YqkBeAR35hWk
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| "drafted. Please provide a value of type string.", | ||
| "title": "Thread Id", | ||
| # TODO: this seems wrong, why both type and anyof | ||
| "type": "string", | ||
| "default": None, | ||
| "anyOf": [ | ||
| {"type": "string"}, | ||
| {"type": "null"}, | ||
| ], | ||
| }, | ||
| }, | ||
| "required": [ | ||
| "message_body", | ||
| ], | ||
| "title": "CreateDraftRequest", | ||
| "type": "object", | ||
| }, | ||
| }, | ||
| "type": "function", | ||
| }, |
There was a problem hiding this comment.
🤖 Bug Fix:
Redundant Schema Definition in 'CreateDraftRequest'
The current schema definition for 'CreateDraftRequest' includes both a 'type' field and an 'anyOf' field, which is redundant and can lead to confusion in validation logic. If the intention is to allow both strings and null values, the 'type' field should be removed, and 'anyOf' should be used exclusively. Alternatively, if only strings are allowed, the 'anyOf' field should be removed. This will ensure clarity and correctness in the schema definition.
🔧 Suggested Code Diff:
- "type": "string",
+ // Remove the 'type' field if allowing both strings and null values📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| "drafted. Please provide a value of type string.", | |
| "title": "Thread Id", | |
| # TODO: this seems wrong, why both type and anyof | |
| "type": "string", | |
| "default": None, | |
| "anyOf": [ | |
| {"type": "string"}, | |
| {"type": "null"}, | |
| ], | |
| }, | |
| }, | |
| "required": [ | |
| "message_body", | |
| ], | |
| "title": "CreateDraftRequest", | |
| "type": "object", | |
| }, | |
| }, | |
| "type": "function", | |
| }, | |
| { | |
| "CreateDraftRequest": { | |
| "type": "object", | |
| "properties": { | |
| "message_body": { | |
| "anyOf": [ | |
| {"type": "string"}, | |
| {"type": "null"} | |
| ], | |
| "default": None | |
| } | |
| }, | |
| "required": [ | |
| "message_body" | |
| ], | |
| "title": "CreateDraftRequest" | |
| } | |
| } |
|
|
||
| ; TODO: Extract plugin tests separately | ||
| ; Installing separately because of the dependency conflicts | ||
| uv pip install plugins/langchain --no-deps | ||
| uv pip install plugins/langchain | ||
|
|
||
| pytest -vvv -rfE --doctest-modules composio/ tests/ swe/tests --junitxml=junit.xml --cov=composio --cov=examples --cov=swe --cov-report=html --cov-report=xml --cov-report=term --cov-report=term-missing --cov-config=.coveragerc {posargs} | ||
| pytest -vvv -rfE --doctest-modules composio/ tests/ swe/tests --ignore tests/test_tools/test_plugins.py --junitxml=junit.xml --cov=composio --cov=examples --cov=swe --cov-report=html --cov-report=xml --cov-report=term --cov-report=term-missing --cov-config=.coveragerc {posargs} | ||
|
|
||
| ; uv pip install plugins/autogen | ||
| ; uv pip install plugins/claude | ||
| ; uv pip install plugins/crew_ai | ||
| ; uv pip install plugins/griptape | ||
| ; uv pip install plugins/julep | ||
| ; uv pip install plugins/lyzr | ||
| ; uv pip install plugins/openai | ||
|
|
There was a problem hiding this comment.
Ensure Comprehensive Test Coverage for Excluded Test File
The recent change excludes tests/test_tools/test_plugins.py from the main test suite, which could lead to gaps in test coverage. It's crucial to ensure that this test file is included in a new dedicated job for plugin tests, especially under Python 3.10. This will help maintain comprehensive test coverage and prevent potential bugs from going unnoticed.
Actionable Steps:
- Verify that
tests/test_tools/test_plugins.pyis included in a separate test job. - Ensure that the new job runs under Python 3.10 to maintain compatibility and coverage.
- Regularly review test coverage reports to confirm no tests are omitted inadvertently.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on e93a7f6 in 10 seconds
More details
- Looked at
36lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. python/tests/test_tools/test_plugins.py:1
- Draft comment:
Remove unused imports to clean up the code.composio_crewai,composio_langchain, andcomposio_llamaindexare not used in this file. - Reason this comment was not posted:
Confidence changes required:50%
The import statements for unused modules intest_plugins.pyshould be removed to clean up the code.
Workflow ID: wflow_Qj9d71JEQRYgNIkg
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 7425b2f in 7 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. python/tox.ini:134
- Draft comment:
Combine plugin installations into a single command to improve performance and reduce redundancy. - Reason this comment was not posted:
Confidence changes required:50%
Thetox.inifile has been updated to include environment variables for thepluginstest environment, which is a good practice for managing configurations. However, thedepssection can be optimized by combining the plugin installations into a single command to improve performance.
Workflow ID: wflow_c8wdNMY7z9PIs7EG
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Important
Add test for input serialization in
get_tools()and optimizeSentenceTransformerimport for lazy loading.test_openai_toolset()intest_plugins.pyto test input serialization inget_tools()ofComposioToolSet.create_draftaction with parametersmessage_bodyandthread_id.SentenceTransformerimport insideEmbedding.__init__()inembedder.pyfor lazy loading.tox.inito install multiple plugins in a single command.This description was created by
for 7425b2f. It will automatically update as commits are pushed.