Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pick active connection only #1152

Merged
merged 1 commit into from
Jan 3, 2025
Merged

feat: pick active connection only #1152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions js/src/sdk/base.toolset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,8 @@ export class ComposioToolSet {
// fetch connected account id
const connectedAccounts = await this.client.connectedAccounts.list({
user_uuid: entityId,
status: "ACTIVE",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The status: "ACTIVE" parameter is redundant when showActiveOnly: true is used. Consider removing status: "ACTIVE".

showActiveOnly: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be redundancy in the parameters. Both status: "ACTIVE" and showActiveOnly: true seem to serve the same purpose. Consider using just one of these parameters to maintain cleaner code. Additionally, the string literal "ACTIVE" should be defined as a constant for better maintainability.

});
accountId = connectedAccounts?.items[0]?.id;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code assumes there will be active accounts by directly accessing items[0]. Consider adding explicit error handling for cases where no active accounts are found. For example:

if (!connectedAccounts?.items?.length) {
  throw CEG.getCustomError(
    COMPOSIO_SDK_ERROR_CODES.SDK.NO_ACTIVE_ACCOUNT_FOUND,
    {
      message: "No active connected account found for the user",
      description: "Please ensure user has at least one active connected account",
    }
  );
}

}
Expand Down
Loading