Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@action decorator #255

Merged
merged 46 commits into from
Jul 10, 2024
Merged

@action decorator #255

merged 46 commits into from
Jul 10, 2024

Conversation

angrybayblade
Copy link
Collaborator

No description provided.

kaavee315 and others added 30 commits July 2, 2024 14:09
@kaavee315
Tmp
27de360
@kaavee315
Update
6c67972
@kaavee315
Add toolset
3414ff2
@angrybayblade
chore: move composio/local_tools -> composio/tools/local
36e5447
@angrybayblade
chore: move composio/core/local -> composio/tools/local/base
0c182ef
@shubhras01 @kaavee315
changes
6da51c2
@shubhras01 @kaavee315
fixing taskgroup in asyncio lib
78bb429
@shubhras01 @kaavee315
adding task context manager
94249fc
@shubhras01 @kaavee315
remove absolute file paths
2dc183a
@shubhras01 @kaavee315
remove docker files
596fc26
@shubhras01 @kaavee315
add generate report card
ed01c7f
@angrybayblade
chore: finish restructuring
02fe0e7
@kaavee315
Formatting changes
dab0d48
@kaavee315
Update log director
3efc300
@kaavee315
Update
5ea77ab
@kaavee315
Add license
1bb3794
@angrybayblade
feat: add execution environments
6f23691
@angrybayblade
fix: imports on examples
7431114
@kaavee315
Update shell cmds
7dfedb8
@angrybayblade
SWE Templates (#247)
a8c25a9
@shubhras01
add logic to generate dockerfiles for swe run
101c16b
@shubhras01
changes
a565a64
@kaavee315
Fix eval
c35ed8d
@kaavee315
Fix eval - Push unmerged changes
78edaf3
@shubhras01
format fixes
0d49bc8
@kaavee315
Lint
3fbeedd
@shubhras01
format fix
d696211
@shubhras01
format fix
b7ecc3a
@shubhras01
docker file gen
6ee3c27
@shubhras01
scripts for docker images
04a5ce3
shubhras01 and others added 12 commits July 4, 2024 20:40
@shubhras01 @angrybayblade @kaavee315
feat: adding swe-bench docker to improve evaluation (#246)
14e1c85 
- adds swe-bench-docker repo code to improve and run evaluation on
docker
tasks:
- [ ] add evaluation function as part of run_eval script
- [ ] build docker images and push it to public docker repo 
- [ ] use the same docker image to run composio-swe

---------

Co-authored-by: Viraj <35092918+angrybayblade@users.noreply.github.com>
Co-authored-by: Karan Vaidya <kaavee315@gmail.com>
@kaavee315
Push local changes
b6fbf3e
@shubhras01
docker file generation
4ca9616
@shubhras01
remove makefile
482a837
@shubhras01
merge fixed run_evaluation
45c0963
@kaavee315
Fix import
51426cc
@angrybayblade
Linters (#252)
6edc01c
@angrybayblade
feat: define composio execute
1e511e3
@angrybayblade
feat: extract execute_action to workspaces
a4912da
@angrybayblade
feat: add support for @action decorator
17613e7
@angrybayblade
fix: linters
bb3fb34
@angrybayblade
Merge branch 'master' into feat/tool-decorator
01a3ab6
@ellipsis-dev ellipsis.dev
Copy link
Contributor

ellipsis-dev bot commented Jul 5, 2024

Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev for $20/seat/month or reach us at help@ellipsis.dev

@angrybayblade angrybayblade changed the title Feat/tool decorator @tool decorator Jul 5, 2024
@kaavee315
Copy link
Contributor

/review
--pr_reviewer.num_code_suggestions="8"
--pr_reviewer.inline_code_comments=true

@codiumai-pr-agent-pro CodiumAI PR-Agent Pro
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Possible Bug:
The implementation of SentinalObject in python/composio/client/enums/_action.py might cause issues if not handled properly. The __init__ method of Action class raises a ValueError if the value has an attribute sentinal, which might not be the intended behavior for all use cases.

Design Concern:
The use of SentinalObject across various classes could lead to confusion and maintenance issues. It's used to mark classes and seems to be a workaround rather than a robust design solution.

@ComposioHQ ComposioHQ deleted a comment from codiumai-pr-agent-pro bot Jul 9, 2024
@ComposioHQ ComposioHQ deleted a comment from codiumai-pr-agent-pro bot Jul 9, 2024
@angrybayblade angrybayblade changed the title @tool decorator @action decorator Jul 9, 2024
@angrybayblade angrybayblade merged commit 1610142 into master Jul 10, 2024
5 checks passed
@angrybayblade angrybayblade deleted the feat/tool-decorator branch July 10, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codiumai-pr-agent-pro codiumai-pr-agent-pro[bot] codiumai-pr-agent-pro[bot] left review comments

@kaavee315 kaavee315 kaavee315 approved these changes

Assignees
No one assigned
Labels
Review effort [1-5]: 4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angrybayblade @kaavee315 @shubhras01