Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate method for customer expected fields #721

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

angrybayblade
Copy link
Collaborator

@angrybayblade angrybayblade commented Oct 17, 2024

Important

Add get_expected_params_for_user() and rename get_expected_params() to get_auth_scheme_for_app() in ComposioToolSet.

  • Methods:
    • Add get_expected_params_for_user() to ComposioToolSet for retrieving expected fields for a user.
    • Rename get_expected_params() to get_auth_scheme_for_app() in ComposioToolSet for clarity.
  • Imports:
    • Remove unused import AuthSchemeField from toolset.py.

This description was created by Ellipsis for 7d3de10. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7d3de10 in 13 seconds

More details
  • Looked at 69 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. python/composio/tools/toolset.py:1042
  • Draft comment:
    Consider providing more guidance in the error message on how to obtain the integration ID if it's not available.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The method get_expected_params_for_user is added to retrieve expected input fields for a user based on integration ID or app. The logic seems correct, but there is a potential issue with the error message in the exception handling block. The message suggests creating an integration, but it might be more helpful to provide guidance on how to obtain the integration ID if it's not available.

Workflow ID: wflow_HMrDWFrP5Az8sV6Z


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-11381070999/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-11381070999/html-report/report.html

@angrybayblade angrybayblade merged commit 2e2e0b4 into master Oct 17, 2024
6 of 7 checks passed
@angrybayblade angrybayblade deleted the feat/expected-params branch October 17, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants