Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth params docs #752

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Auth params docs #752

merged 2 commits into from
Oct 22, 2024

Conversation

angrybayblade
Copy link
Collaborator

@angrybayblade angrybayblade commented Oct 22, 2024

Important

Update Python code snippet in connected_account.mdx to use connectionStatus instead of status.

  • Docs:
    • Update Python code snippet in connected_account.mdx to use connectionStatus instead of status for connection_request object.

This description was created by Ellipsis for 35bf55e. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 35bf55e in 9 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. docs/patterns/Auth/connected_account.mdx:85
  • Draft comment:
    Ensure that connectionStatus is used consistently across all examples if this is the intended change. Currently, it is updated in the Python example but not in the JavaScript example.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_zAKWydWBGf9Qku89


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Oct 22, 2024

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-11458245966/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-11458245966/html-report/report.html

@angrybayblade angrybayblade merged commit a1a9d4a into master Oct 22, 2024
6 of 7 checks passed
@angrybayblade angrybayblade deleted the fix/auth-docs branch October 22, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants