-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add error telemetry support #778
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to aece8c6 in 19 seconds
More details
- Looked at
131
lines of code in5
files - Skipped
1
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. js/src/exceptionHandler.ts:1
- Draft comment:
The importversion
from 'os' is unused and can be removed. - Reason this comment was not posted:
Confidence changes required:50%
The import statement for 'version' from 'os' is unused in the file. It should be removed to clean up the code.
2. js/src/index.ts:4
- Draft comment:
Remove the extra semicolon at the end of the import statement. - Reason this comment was not posted:
Confidence changes required:10%
There is an extra semicolon at the end of the import statement for OpenAIToolSet. This is a minor syntax issue.
Workflow ID: wflow_DB9w4m2FR9djsba7
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
nodeVersion: process.version | ||
}; | ||
|
||
axios.post(`${baseURL}/api/v1/sdk/error`, payload); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using await
with axios.post
to handle potential promise rejections.
axios.post(`${baseURL}/api/v1/sdk/error`, payload); | |
await axios.post(`${baseURL}/api/v1/sdk/error`, payload); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 796467d in 6 seconds
More details
- Looked at
9
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_Wvqbv3JTILlQn1Dl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
Hey @himanshu-dixit, here are examples of how you can ask me to improve this pull request: @Sweep Fix the CI errors. @Sweep Add unit tests for `logError` function in `exceptionHandler.ts` to verify: 📖 For more information on how to use Sweep, please read our documentation. |
Important
Adds error telemetry support with global error handling and logging in
exceptionHandler.ts
, and updates related configurations.exceptionHandler.ts
to log errors to a remote server using Axios.logError()
andsetupErrorHandlers()
for global error handling.COMPOSIO_VERSION
fromconstants.js
in error payload.COMPOSIO_VERSION
toconstants.js
.exceptionHandler
inindex.ts
to initialize error handling.typedoc.json
to include new entry points and exclude*.spec.ts
files.This description was created by for 796467d. It will automatically update as commits are pushed.