Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix custom action flow #791

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix custom action flow #791

merged 1 commit into from
Oct 28, 2024

Conversation

sohamganatra
Copy link
Contributor

@sohamganatra sohamganatra commented Oct 28, 2024

Important

Fixes and updates custom action flow in documentation, including code snippets and descriptions for Gmail and new tool actions.

  • Custom Action Flow:
    • Updated my_custom_action in custom_actions.mdx to fetch emails from Gmail for the last 24 hours using existing authentication.
    • Changed parameter from query to account_id in Python and JavaScript examples.
    • Updated JavaScript action name from fetchEmails to myCustomAction.
  • Code Snippets:
    • Updated Python and JavaScript code snippets to reflect new logic for fetching emails and handling account IDs.
    • Added error handling and logging improvements in both languages.
  • Documentation:
    • Updated import statements and initialization examples in integrations.mdx and custom_actions.mdx.
    • Improved descriptions and comments for clarity and accuracy.

This description was created by Ellipsis for a032e0c. It will automatically update as commits are pushed.

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 1:38pm

Copy link

sweep-ai bot commented Oct 28, 2024

Hey @sohamganatra, here is an example of how you can ask me to improve this pull request:

@Sweep Add unit tests for the `my_custom_action` Gmail function to verify:
- Correct URL construction with different account_id values (including 'me' and empty string)
- Proper handling of auth dictionary parameters
- Correct timestamp calculation for the 24-hour window

📖 For more information on how to use Sweep, please read our documentation.

@sohamganatra sohamganatra merged commit 9bf8b75 into master Oct 28, 2024
4 checks passed
@sohamganatra sohamganatra deleted the fix/custom-action branch October 28, 2024 13:38
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to a032e0c in 34 seconds

More details
  • Looked at 249 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_H1p0ujkxeQjQA57t


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -42,27 +42,36 @@ As `gmail` toolname is already registered in Composio, `auth` dictionary will be
</Note>
<CodeGroup>
```python Custom Action - Gmail (python)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The datetime module is used but not imported. Add import datetime at the beginning of the code snippet.

Suggested change
```python Custom Action - Gmail (python)
import datetime

Copy link

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-11555176672/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-11555176672/html-report/report.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant