Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: small cleanups #793

Merged
merged 3 commits into from
Oct 29, 2024
Merged

chore: small cleanups #793

merged 3 commits into from
Oct 29, 2024

Conversation

tushar-composio
Copy link
Collaborator

@tushar-composio tushar-composio commented Oct 28, 2024

Important

This pull request cleans up code, updates URLs, and removes unnecessary files to improve maintainability.

  • Code Cleanups:
    • Remove unused imports in toolset.py and composio_langchain/toolset.py.
    • Simplify query parameter handling in endpoints.py.
    • Remove deprecated V1BaseModel handling in toolset.py.
    • Remove pydantic.v1.error_wrappers usage in utils/pydantic.py and composio_langchain/toolset.py.
  • URL Updates:
    • Update GitHub URLs in setup.py and swe/setup.py.
  • File Removals:
    • Delete package.json, playwright.config.ts, session.json, and tools.py from tests directory.

This description was created by Ellipsis for d26d62f. It will automatically update as commits are pushed.

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 3:16pm

Copy link

sweep-ai bot commented Oct 28, 2024

Hey @tushar-composio, here is an example of how you can ask me to improve this pull request:

@Sweep Add unit tests for the new `Endpoint` query parameter handling in `endpoints.py` to verify that URL encoding and query string construction works correctly with:
- Empty query parameters
- Single query parameter
- Multiple query parameters
- Query parameters containing special characters that need encoding

📖 For more information on how to use Sweep, please read our documentation.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 5b95a52 in 43 seconds

More details
  • Looked at 484 lines of code in 11 files
  • Skipped 1 files when reviewing.
  • Skipped posting 7 drafted comments based on config settings.
1. python/composio/client/__init__.py:1
  • Draft comment:
    The removal of the # fmt: off comment is appropriate as it is not needed here. The code is already formatted properly.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The removal of the 'fmt: off' comment is appropriate as it is not needed here. The code is already formatted properly.
2. python/composio/client/__init__.py:64
  • Draft comment:
    Adding a trailing comma to the runtime parameter in the constructor is a good practice for future additions.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The trailing comma added to the runtime parameter in the constructor is a good practice for future additions.
3. python/composio/client/endpoints.py:59
  • Draft comment:
    The refactoring of the URL query parameter construction is more efficient and cleaner.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The refactoring of the URL query parameter construction is more efficient and cleaner.
4. python/composio/tools/toolset.py:578
  • Draft comment:
    The removal of the V1BaseModel check is appropriate since it is not used anymore.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The removal of the V1BaseModel check is appropriate since it is not used anymore.
5. python/composio/utils/pydantic.py:1
  • Draft comment:
    The removal of the pydantic.v1.error_wrappers import is correct since it's not used anymore.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The removal of the pydantic.v1.error_wrappers import is correct since it's not used anymore.
6. python/setup.py:99
  • Draft comment:
    The update to the GitHub URL is correct and reflects the new repository location.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The update to the GitHub URL is correct and reflects the new repository location.
7. python/swe/setup.py:44
  • Draft comment:
    The update to the GitHub URL is correct and reflects the new repository location.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The update to the GitHub URL is correct and reflects the new repository location.

Workflow ID: wflow_St4QzPVxOg9yDlQ1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Oct 28, 2024

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-11557022805/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-11557022805/html-report/report.html

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on d26d62f in 16 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. python/composio/client/__init__.py:261
  • Draft comment:
    Unnecessary trailing comma added. Remove it for consistency. This applies to line 276 as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR description mentions removing unused imports, but there are no changes in this file related to imports. However, there are trailing commas added in the execute method, which are unnecessary and not mentioned in the PR description.

Workflow ID: wflow_AHuz4xGncqioKsJd


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@angrybayblade angrybayblade merged commit 268e690 into master Oct 29, 2024
9 checks passed
@angrybayblade angrybayblade deleted the little-cleanups branch October 29, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants