Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add error message details #922

Merged
merged 12 commits into from
Nov 28, 2024
Merged

feat: add error message details #922

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1842dea
feat: add error message details
himanshu-dixit Nov 27, 2024
a582e6b
feat: update error
himanshu-dixit Nov 27, 2024
1989d32
feat: x request id
himanshu-dixit Nov 28, 2024
aa8f2be
fix: change errors
himanshu-dixit Nov 28, 2024
d3bf70d
Delete js/sample.ts
plxity Nov 28, 2024
08def0a
feat: error
himanshu-dixit Nov 28, 2024
251f920
Merge branch 'feat-random-errors-details' of github.com:ComposioHQ/co…
himanshu-dixit Nov 28, 2024
0fe5285
feat: error code
himanshu-dixit Nov 28, 2024
700aea2
Merge branch 'master' into feat-random-errors-details
plxity Nov 28, 2024
0d4a4fd
Merge branch 'master' into feat-random-errors-details
plxity Nov 28, 2024
7e38dc6
feat: bump version
himanshu-dixit Nov 28, 2024
47db66c
Merge branch 'feat-random-errors-details' of github.com:ComposioHQ/co…
himanshu-dixit Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion js/src/sdk/utils/error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,14 @@ export class CEG {
errorKey = ERROR.BACKEND.UNKNOWN;
break;
}
if (errorKey) {
if (errorKey !== ERROR.BACKEND.UNKNOWN) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition errorKey !== ERROR.BACKEND.UNKNOWN might be more clear as errorKey && errorKey !== ERROR.BACKEND.UNKNOWN to explicitly handle cases where errorKey might be undefined or null.

errorDetails = PREDEFINED_ERROR_REGISTRY[errorKey];
}else{
errorDetails = {
message: axiosError.message,
description: axiosError.response.data.message || axiosError.response.data.error || axiosError.message,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding null/undefined checks for axiosError.response and axiosError.response.data to prevent potential runtime errors. You could use optional chaining:

description: axiosError.response?.data?.message || 
             axiosError.response?.data?.error || 
             axiosError.message

possibleFix: "Please check the network connection, request parameters, and ensure the API endpoint is correct."
}
}
}

Expand Down
Loading