Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass x-request-id in composio api queries #939

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Conversation

tushar-composio
Copy link
Collaborator

@tushar-composio tushar-composio commented Dec 3, 2024

This will help in tracking request traces across the stack.


Important

Add x-request-id header to HTTP requests for traceability using generate_request_id() function.

  • Behavior:
    • Add x-request-id header to HTTP requests in validate_api_key() in __init__.py, connect() in collections.py, HttpClient in http.py, and _wait_for_machine() in client.py.
    • Use generate_request_id() from shared.py to generate unique request IDs.
  • Utilities:
    • Add generate_request_id() function in shared.py to generate unique request IDs using uuid.uuid4().

This description was created by Ellipsis for e6ce588. It will automatically update as commits are pushed.

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 8:37am

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a8ede76 in 1 minute and 27 seconds

More details
  • Looked at 130 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. python/composio/utils/shared.py:392
  • Draft comment:
    The generate_request_id function correctly uses uuid.uuid4() to generate a unique request ID. This is a standard and efficient approach.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The generate_request_id function is used to generate a unique request ID using uuid.uuid4(). This is a standard way to generate unique identifiers and is appropriate for the use case described in the PR.

Workflow ID: wflow_v3mUgjsQvhSQmaHQ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Dec 3, 2024

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-12135842292/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-12135842292/html-report/report.html

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on cc1659b in 11 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. python/composio/utils/shared.py:7
  • Draft comment:
    Duplicated import statement for Parameter. Consider removing the duplicate to clean up the code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The import statement for 'Parameter' is duplicated, which is unnecessary and can be removed.

Workflow ID: wflow_fCVF62q16Y0i0gjO


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@tushar-composio tushar-composio merged commit 052f103 into master Dec 3, 2024
4 of 5 checks passed
@tushar-composio tushar-composio deleted the ENG-2759 branch December 3, 2024 08:36
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on e6ce588 in 12 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_gN0sPY1MoTjTQ41m


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants