Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing js test #941

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: failing js test #941

merged 1 commit into from
Dec 3, 2024

Conversation

tushar-composio
Copy link
Collaborator

@tushar-composio tushar-composio commented Dec 3, 2024

Important

Fix failing test in apps.spec.ts by including oauth_redirect_uri in OAUTH2 scheme's optional fields.

  • Tests:
    • Update apps.spec.ts to include oauth_redirect_uri in optional_fields for OAUTH2 scheme in two test cases.

This description was created by Ellipsis for 824eb05. It will automatically update as commits are pushed.

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 7:55am

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 824eb05 in 8 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. js/src/sdk/models/apps.spec.ts:55
  • Draft comment:
    The addition of oauth_redirect_uri to optional_fields is consistent with the expected structure of authSchemes. Ensure this change is reflected in the implementation as well.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The changes made in the PR are consistent with the expected structure of the authSchemes object. The addition of oauth_redirect_uri to the optional_fields array is reflected in both test cases, ensuring consistency. No issues found.

Workflow ID: wflow_gwSdvu5R5L9Wqmdm


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@shreysingla11
Copy link
Collaborator

Code Review Summary

The changes look good overall, with a few suggestions for improvement:

Strengths:
✅ The changes correctly align test expectations with the actual implementation
✅ Consistent updates across both test cases
✅ Maintains backward compatibility with existing OAuth2 functionality

Suggestions:

  • Consider adding test cases that verify the actual usage of oauth_redirect_uri
  • Documentation for the OAuth redirect URI functionality might be helpful for SDK users

Overall Rating: 8/10
The changes are necessary and well-implemented, though additional test coverage would make it more robust.

Copy link

github-actions bot commented Dec 3, 2024

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-12135234388/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-12135234388/html-report/report.html

@plxity plxity enabled auto-merge (squash) December 3, 2024 08:14
@tushar-composio tushar-composio merged commit 810802a into master Dec 3, 2024
7 of 9 checks passed
@tushar-composio tushar-composio deleted the fix-js-test branch December 3, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants