-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: failing js test #941
fix: failing js test #941
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 824eb05 in 8 seconds
More details
- Looked at
22
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. js/src/sdk/models/apps.spec.ts:55
- Draft comment:
The addition ofoauth_redirect_uri
tooptional_fields
is consistent with the expected structure ofauthSchemes
. Ensure this change is reflected in the implementation as well. - Reason this comment was not posted:
Confidence changes required:20%
The changes made in the PR are consistent with the expected structure of theauthSchemes
object. The addition ofoauth_redirect_uri
to theoptional_fields
array is reflected in both test cases, ensuring consistency. No issues found.
Workflow ID: wflow_gwSdvu5R5L9Wqmdm
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Code Review SummaryThe changes look good overall, with a few suggestions for improvement: Strengths: Suggestions:
Overall Rating: 8/10 |
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
Important
Fix failing test in
apps.spec.ts
by includingoauth_redirect_uri
in OAUTH2 scheme's optional fields.apps.spec.ts
to includeoauth_redirect_uri
inoptional_fields
for OAUTH2 scheme in two test cases.This description was created by for 824eb05. It will automatically update as commits are pushed.