Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs url slugs #942

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: docs url slugs #942

merged 1 commit into from
Dec 3, 2024

Conversation

tushar-composio
Copy link
Collaborator

@tushar-composio tushar-composio commented Dec 3, 2024

Two new docs pages had incorrect URL slugs.


Important

Fix incorrect URL slugs for two documentation pages by renaming files and updating references in docs/mint.json.

  • Behavior:
    • Corrects URL slugs for two documentation pages in docs/mint.json.
    • Updates slugs from custom-action-for-new-tool to custom-action-without-auth and custom-action-for-existing-tool to custom-action-with-auth.
  • Files:
    • Renames custom-action-for-existing-tool.mdx to custom-action-with-auth.mdx.
    • Renames custom-action-for-new-tool.mdx to custom-action-without-auth.mdx.

This description was created by Ellipsis for 65e0900. It will automatically update as commits are pushed.

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 9:44am

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 65e0900 in 9 seconds

More details
  • Looked at 24 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. docs/mint.json:110
  • Draft comment:
    Ensure that the updated slugs in the JSON file match the renamed files to prevent broken links.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR correctly updates the URL slugs in the JSON file to match the renamed files. This ensures consistency and prevents broken links.

Workflow ID: wflow_0gLwps5k1OG2RvAO


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@shreysingla11
Copy link
Collaborator

Code Review Summary

The changes in this PR improve the documentation structure by making the file names more descriptive and clearer about their purpose:

Positive Changes:

  • More intuitive file names that clearly indicate authentication requirements
  • Proper updates to all references in mint.json
  • Maintains content integrity with 100% similarity in renames
  • Follows consistent naming conventions

The changes are well-executed and improve documentation clarity without introducing any risks. Good to merge! 👍

Copy link

github-actions bot commented Dec 3, 2024

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-12136980433/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-12136980433/html-report/report.html

@tushar-composio tushar-composio merged commit c16dccb into master Dec 3, 2024
7 of 9 checks passed
@tushar-composio tushar-composio deleted the fix-docs-urls branch December 3, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants