fix: Slack step in examples yml #944
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 152f56a in 1 minute and 1 seconds
More details
- Looked at
23lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/examples_js.yml:82
- Draft comment:
Ensure thatSLACK_TECH_WEBHOOKis correctly set in the repository secrets. - Reason this comment was not posted:
Confidence changes required:50%
The change fromSLACK_WEBHOOKtoSLACK_TECH_WEBHOOKseems intentional, but it's important to ensure that this secret is correctly set in the repository settings.
Workflow ID: wflow_A4njGP3gQLK3EQsl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 65d8851 in 12 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/examples_js.yml:83
- Draft comment:
The SLACK_TITLE should be updated to "Example Tests Failed" as per the PR description. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_UPJmRHpY3avqGL8d
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| SLACK_MSG_AUTHOR: ${{ inputs.author || github.actor }} | ||
| SLACK_MESSAGE: "<@team> ${{ inputs.commit_message || github.event.head_commit.message }}" | ||
| SLACK_MESSAGE: "<@Apoorv> <@kaavee> ${{ inputs.commit_message || github.event.head_commit.message }}" |
There was a problem hiding this comment.
Hardcoding specific user mentions (@Apoorv and @kaavee) in the workflow file is not a maintainable practice. Consider:
- Using a team mention instead (
@teamas before) - Or using a configurable environment variable/secret that can store the list of users to notify
This would make it easier to update notification targets without changing the workflow file.
| @@ -79,12 +79,12 @@ jobs: | |||
| if: ${{ failure() && github.ref == 'refs/heads/master' && !contains(github.event.head_commit.message, 'release') && !contains(github.event.head_commit.message, 'Release') && !inputs.dont_notify }} | |||
| uses: rtCamp/action-slack-notify@v2 | |||
| env: | |||
| SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} | |||
| SLACK_TITLE: "JS Example Tests Failed" | |||
| SLACK_WEBHOOK: ${{ secrets.SLACK_TECH_WEBHOOK }} | |||
There was a problem hiding this comment.
The change from SLACK_WEBHOOK to SLACK_TECH_WEBHOOK represents a significant configuration change. Please ensure:
- The new webhook secret is properly configured in repository settings
- The new webhook has appropriate permissions and is pointing to the correct Slack channel
- Consider adding a comment explaining why this webhook change was necessary
Code Review SummaryChanges OverviewThe PR modifies the Slack notification configuration in the JavaScript example tests workflow. Code Quality Assessment:
|
|
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
Important
Update Slack notification details in
examples_js.ymlto notify specific users and change message content.examples_js.yml:SLACK_WEBHOOKfromSLACK_WEBHOOKtoSLACK_TECH_WEBHOOK.SLACK_TITLEfrom "JS Example Tests Failed" to "Example Tests Failed".SLACK_MESSAGEto notify<@Apoorv> <@kaavee>instead of<@team>.SLACK_FOOTERfrom "Failed JS Example Tests | GitHub Actions" to "Failed Example Tests | GitHub Actions".This description was created by
for 65d8851. It will automatically update as commits are pushed.