Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: composio apps update revamp #962

Merged
merged 59 commits into from
Dec 11, 2024
Merged

feat: composio apps update revamp #962

merged 59 commits into from
Dec 11, 2024

Conversation

tushar-composio
Copy link
Collaborator

@tushar-composio tushar-composio commented Dec 7, 2024

What's done:

  • Simplified the way enums work at runtime
  • Removed the composio apps update command, as apps will always be synced at startup now.
  • Added more tests for enums to ensure old behaviour doesn't break
  • Added a replaced_by field into the ActionData class to be used by deprecated actions, and in-turn the local cache JSON files also get that field.
  • Ensure that if replaced_by is not present in the locally cached version, load it from remote.
  • Generate .pyi type stub files for the enums, and put them in the repository
    • Ensure these files get bundled into the composio repository, alongside the py.typed file
  • Create a composio apps generate-types cli call to update these .pyi files
  • Check the first Action enum in the local cache, if it exists and doesn't have a replaced_by field, refresh the entire cache. The fetching of ALL actions will only happen once when you update to this new composio version.
  • Check for NO_CACHE_REFRESH env var to disable startup stuff

What's left:

  • At startup time:
    • Checking for missing enums by comparing the list in API and local cache
    • Deleting any enums from local cache that no longer exist in the API
    • Downloading any enums that are on the API but not on local (do this parallelly)
    • (These startup changes will be done soon after the backend has an endpoint for fetching enum names very quickly)

Copy link

vercel bot commented Dec 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 11:43am

Copy link
Contributor

ellipsis-dev bot commented Dec 7, 2024

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at help@ellipsis.dev


Generated with ❤️ by ellipsis.dev

Copy link

github-actions bot commented Dec 7, 2024

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-12273208336/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-12273208336/html-report/report.html

@tushar-composio tushar-composio enabled auto-merge (squash) December 11, 2024 11:45
@tushar-composio tushar-composio merged commit 983322d into master Dec 11, 2024
9 checks passed
@tushar-composio tushar-composio deleted the ENG-2824 branch December 11, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants