-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle remote enums fetching dynamically #963
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on cc1d11c in 19 seconds
More details
- Looked at
12
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. python/composio/client/enums/_action.py:4947
- Draft comment:
The PR description states thatPEOPLEDATALABS_SEARCH_PERSON_DATA
is removed from theAction
enum, but the diff shows it being added. Please clarify this discrepancy. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_TtyLbaaCnBOT7Vez
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 0ce948d in 1 minute and 33 seconds
More details
- Looked at
97
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
5
drafted comments based on config settings.
1. python/composio/tools/env/host/workspace.py:174
- Draft comment:
Theis_action
function is defined here and incollections.py
with the same logic. Consider refactoring it into a utility function to avoid code duplication. - Reason this comment was not posted:
Confidence changes required:50%
The functionis_action
is defined twice in different files with the same logic. It would be better to refactor this into a utility function to avoid code duplication.
2. python/composio/tools/toolset.py:747
- Draft comment:
Theload_action
function is used here to replace directAction
instantiation. This change improves consistency and error handling across the codebase. - Reason this comment was not posted:
Confidence changes required:0%
Theload_action
function is used multiple times intoolset.py
to replace directAction
instantiation. This is a good change for consistency and error handling.
3. python/composio/tools/toolset.py:867
- Draft comment:
Theload_action
function is used here to replace directAction
instantiation. This change improves consistency and error handling across the codebase. - Reason this comment was not posted:
Confidence changes required:0%
Theload_action
function is used multiple times intoolset.py
to replace directAction
instantiation. This is a good change for consistency and error handling.
4. python/composio/tools/toolset.py:889
- Draft comment:
Theload_action
function is used here to replace directAction
instantiation. This change improves consistency and error handling across the codebase. - Reason this comment was not posted:
Confidence changes required:0%
Theload_action
function is used multiple times intoolset.py
to replace directAction
instantiation. This is a good change for consistency and error handling.
5. python/plugins/openai/composio_openai/toolset.py:179
- Draft comment:
Theload_action
function is used here to replace directAction
instantiation. This change improves consistency and error handling across the codebase. - Reason this comment was not posted:
Confidence changes required:0%
Theload_action
function is used multiple times intoolset.py
to replace directAction
instantiation. This is a good change for consistency and error handling.
Workflow ID: wflow_gfTHgzxAFOzDERI5
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 36eb604 in 16 seconds
More details
- Looked at
36
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. python/plugins/langchain/composio_langchain/toolset.py:85
- Draft comment:
Ensure thataction
is properly defined or imported, as theAction
import was removed. This might cause a runtime error ifaction
is not defined elsewhere. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_Qsc1EeMELLG6mFa3
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 7500e92 in 12 seconds
More details
- Looked at
372
lines of code in17
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. python/plugins/autogen/setup.py:12
- Draft comment:
Ensure that the use of a release candidate version (0.5.52-rc.1) aligns with the project's release strategy. This versioning is consistent across all plugins and core packages. - Reason this comment was not posted:
Confidence changes required:33%
The versioning in the setup.py files has been updated to a release candidate version (0.5.52-rc.1). This is consistent across all plugins and core packages, which is good for consistency. However, it's important to ensure that this versioning strategy aligns with the overall release strategy of the project.
Workflow ID: wflow_zbVKtxzffg1UD7sN
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 1385ca4 in 13 seconds
More details
- Looked at
47
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. python/composio/tools/env/host/workspace.py:174
- Draft comment:
Consider refactoring the repeated logic of converting actions toAction
objects into a utility function to avoid code duplication and improve maintainability. This logic is also present incollections.py
. - Reason this comment was not posted:
Confidence changes required:50%
The code incheck_for_missing_dependencies
uses a list comprehension to convert actions toAction
objects if they are not already instances ofAction
. This is a good practice to ensure type consistency. However, the same logic is repeated incollections.py
. It would be better to refactor this into a utility function to avoid code duplication and improve maintainability.
Workflow ID: wflow_aPdWaJL7y5JznpIn
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Enhances
Action
handling by addingis_action
utility, usingload_action
for instantiation, and updating dependencies and versioning.is_action
function incollections.py
andworkspace.py
to check if an object is anAction
.Action
instantiation withload_action
intoolset.py
andcomposio_openai/toolset.py
.PEOPLEDATALABS_SEARCH_PERSON_DATA
fromAction
enum in_action.py
.get()
incollections.py
to useis_action
.check_for_missing_dependencies()
inworkspace.py
to useis_action
.execute_action()
andvalidate_tools()
intoolset.py
to useload_action
.execute_tool_call()
incomposio_openai/toolset.py
to useload_action
.0.5.52-rc.1
in__version__.py
and multiplesetup.py
files.composio_core
dependency version in multiplesetup.py
files.This description was created by for 1385ca4. It will automatically update as commits are pushed.