feat: move to object params for methods + processor support

[himanshu-dixit]

Important

Refactor code to use destructured parameters and Zod validation, update tests, and improve logging and error handling.

• Refactoring:
  • Destructure parameters in executeAction in base.toolset.ts and execute in Entity.ts.
  • Use Zod for parameter validation in Entity.ts for execute and initiateConnection.
  • Update method signatures to use destructured objects in getConnection and setupTrigger in Entity.ts.
• Tests:
  • Update tests in index.spec.ts, Entity.spec.ts, apps.spec.ts, and triggers.spec.ts to match new method signatures.
• Misc:
  • Remove unused imports in base.toolset.ts.
  • Minor updates to logging and error handling across files.

^{This description was created by for 1f85150. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Incremental review on 2629a82 in 22 seconds

More details

• Looked at 249 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. js/src/sdk/base.toolset.ts:41

• Draft comment:
  Avoid using @ts-expect-error to bypass TypeScript checks. Ensure toolResponse.data.response_data is properly typed to avoid errors.
• Reason this comment was not posted:
  Comment did not seem useful.

2. js/src/sdk/base.toolset.ts:55

• Draft comment:
  Avoid using @ts-ignore to bypass TypeScript checks. Ensure toolResponse.data.response_data is properly typed to avoid errors.
• Reason this comment was not posted:
  Marked as duplicate.

3. js/src/sdk/base.toolset.ts:312

• Draft comment:
  Avoid using @ts-ignore to bypass TypeScript checks. Ensure data.response_data is properly typed to avoid errors.
• Reason this comment was not posted:
  Marked as duplicate.

4. js/src/sdk/base.toolset.ts:337

• Draft comment:
  Consider making the error message more descriptive to indicate which processor type is invalid.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The addPreProcessor and addPostProcessor methods throw an error if the processor is not a function. This is a good practice for type safety. However, the error message could be more descriptive to indicate which processor type is invalid.

Workflow ID: wflow_AsLBiLcF9rGpPfd0

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on f19cac4 in 16 seconds

More details

• Looked at 77 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. js/src/sdk/base.toolset.ts:73

• Draft comment:
  Consider renaming the parameter processor to postProcessor in the addPostProcessor method for consistency with addPreProcessor.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The type alias TProcessor was renamed to TPreProcessor in the code, but the type alias TPostProcessor was not updated in the addPostProcessor method. This inconsistency should be addressed for clarity and consistency.

Workflow ID: wflow_3tAy8DclxTCFdqCj

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[utkarsh-dixit]

Keep it here, if anything let's deprecate it and remove it sometime in the future to avoid breaking running code

[himanshu-dixit]

Done

[ellipsis-dev]

👍 Looks good to me! Incremental review on 1f85150 in 11 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_97G4xtDl00TenWRE

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.