Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments: Default to resource group location rather than West Europe. #1138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ninjarobot
Copy link
Collaborator

This PR improves the default behavior when no location is specified, improving upon the issue in #682, although not quite fixing it yet.

The changes in this PR are as follows:

  • Deployments: Default to resource group location rather than West Europe.

I have read the contributing guidelines and have completed the following:

  • Tested my code end-to-end against a live Azure subscription.
  • Updated the documentation in the docs folder for the affected changes.
  • Written unit tests against the modified code that I have made.
  • Updated the release notes with a new entry for this PR.
  • Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

@ninjarobot
Copy link
Collaborator Author

@isaacabraham what do you think of this change to remove the default of "westeurope"? The only place it's really breaking is if people don't specify a location and are letting Deploy.execute create the resource group. I think most people that use Deploy.execute are actually specifying a location. The alternative would be to have Deploy.execute default to westeurope so it has the old behavior. Thoughts?

@isaacabraham
Copy link
Member

Yes, removing defaults is probably a good thing.

@isaacabraham
Copy link
Member

What happens if they don't specify a location - will it error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants