Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work to move to GitHub Actions #974

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

isaacabraham
Copy link
Member

No description provided.

Copy link
Collaborator

@ninjarobot ninjarobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - my one suggestion is to have a separate workflow for building and publishing the nuget package so it can be triggered on releases instead of on merges.

run: dotnet build -c release
- name: Run Tests
run: dotnet test -c release -l trx --collect:"XPlat Code Coverage"
- name: Create NuGet Package
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to consider moving this to a different action so it's triggered when releases are created rather than on every push to master. Here's an example from one of my other projects.

@martinbryant
Copy link
Contributor

@isaacabraham any chance you will have some time to re visit this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants