NVML: Handle Unsupported GPU Serial #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch errors if NVML can not query the device serial number, e.g. on Quadro, Mobile or other product lines.
ax3l
force-pushed
the
fix-nvmlUnsupportedDevice
branch
from
9499b0a to
86303be
Compare
ax3l
commented
Oct 11, 2018
|
|
||
| unsigned int serialLength = NVML_DEVICE_SERIAL_BUFFER_SIZE; | ||
| NVML_CHECK(nvmlDeviceGetSerial( devHandle, serial, serialLength )); | ||
| unsigned int serialLength = NVML_DEVICE_SERIAL_BUFFER_SIZE; |
There was a problem hiding this comment.
constant is 30
Safe std::strncpy used below with a string that is 28 chars and is therefore usually not cropped. Null-added manuall in case it gets cropped.
ax3l
changed the title
21 tasks
psychocoderHPC
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch errors if NVML can not query the device serial number, e.g. on Quadro, Mobile or other product lines.
Fix #16