Fix sliceFieldReader #2718
Merged
Fix sliceFieldReader #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace `map()` by list comprehension, correct spelling error in comment
ax3l
added
component: plugin
ax3l
reviewed
Oct 8, 2018
| @@ -77,7 +77,7 @@ def readFieldSlices(File): | |||
| # go through all valid field vectors | |||
| for x in range(N_x): | |||
| fieldValue = line[x] | |||
| data[y, x, :] = map(float, fieldValue[1:-1].split(',')) | |||
| data[y, x, :] = [ float(x) for x in fieldValue[1:-1].split(',') ] | |||
There was a problem hiding this comment.
looks good!
Please just fix the style by removing the whitespaces after [ and before ] to make the CI happy :)
ax3l
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of
map()changed from Python 2 to 3 which results in an error when using the function now. This PR avoids the map function but uses a (more pythonic) list comprehension which is also version independent.A grammar error in a comment is corrected as well.