Visualizers: axes passed on startup #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ax3l
reviewed
Oct 15, 2018
| @@ -37,6 +41,10 @@ def __init__(self, run_directory): | |||
| self.data_reader = self._create_data_reader(run_directory) | |||
| self.data = None | |||
|
|
|||
| if ax is None: | |||
| print("Warning: No axes was given, using plt.gca() instead!") | |||
There was a problem hiding this comment.
do you want to use
import warnings
warnings.warn(
"Warning: No axes was given, using plt.gca() instead!",
RuntimeWarning)here?
4 tasks
ax3l
approved these changes
Oct 15, 2018
ax3l
modified the milestones:
0.5.0 / 1.0.0: Next Stable,
0.4.0: CPU Support, Filter & Merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the API of the visualizers a bit clearer by passing the matplotlib axes on creation instead of only passing it in the
visualize(ax,...)call.So far this API kind of suggested that it is possible to switch the figures between multiple visualization calls which in fact does not happen since the
self.plt_objis still tied to the previous axes.Now there should be no ambiguity anymore.
Please merge this before #2691 since this still makes use of the API that is currently used.