reduce example complexity #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove few configurable option in the example to reduce the complextity. - remove param for field solver (reducing the ugly pre-compiler hack to calculate the time step for directinal splitting. - remove param for current interpolation - remove param for current solver
Remove params to chose field solver, current solver, precision.
psychocoderHPC
added
refactoring
psychocoderHPC
force-pushed
the
topic-reduceExampleComplexity
branch
3 times, most recently
from
29c90b1 to
de49808
Compare
Add folder `tests` to the test matrix.
psychocoderHPC
force-pushed
the
topic-reduceExampleComplexity
branch
from
de49808 to
d2b65c0
Compare
|
can be merged |
sbastrakov
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is changing cmake flags in the examples. The feature to compile different setups by changing
cmakeFlagsin the examples is useful for parameter scans and was from us hijacked to compile different solver in our CI.This PR reducing the free parameter for a example to a useful minimum, for the corresponding test.
A new folder
testsis introducing compile tests. We do not aim to test each possible combination for all solvers, with shapes, ...We need to be realistic what we can test within the CI.
Later PRs will introduce unit tests to cover more parts of PIConGPU/PMacc
Incompatibilities
Old files
cmakeFlagfrom the examples are not compatible with this PR. The default case (zero) is always running but other cases can be broken. Broken means that e.g. changing the field solver will have no effect.Review
Please review the PR commit wise. Each example I changed has its own commit.