Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ssh authorized keys options #344

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

cmd-ntrf
Copy link
Member

Also allow more than one key to have the same comment.

Fix #332

@cmd-ntrf cmd-ntrf added bug Something isn't working enhancement New feature or request labels Mar 27, 2024
@cmd-ntrf cmd-ntrf self-assigned this Mar 27, 2024
Copy link
Member

@mboisson mboisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this PR might work in the most common cases, it can also break quite easily.

@cmd-ntrf cmd-ntrf force-pushed the ssh_comment_options branch 3 times, most recently from 593fcad to 1fb81bb Compare March 27, 2024 16:30
Also allow more than one key to have the same comment
@cmd-ntrf cmd-ntrf force-pushed the ssh_comment_options branch from 1fb81bb to 502f2ee Compare March 27, 2024 16:31
@mboisson
Copy link
Member

lgtm

@cmd-ntrf cmd-ntrf merged commit c5d3ab0 into main Mar 28, 2024
2 checks passed
@cmd-ntrf cmd-ntrf deleted the ssh_comment_options branch May 1, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting restricted SSH keys
2 participants