Co-Op Submission Page #138
Conversation
| padding-left: 10px; | ||
| } | ||
|
|
||
| .radio-inline input[type='radio'], .radio input[type='radio'], input[type='radio'] { |
There was a problem hiding this comment.
This is not how this should be selected. It also makes the linter unhappy.
I will figure this out later. (or if someone wants to fix it, I am also fine with that)
conditional/blueprints/co_op.py
Outdated
| logger = structlog.get_logger() | ||
|
|
||
| @co_op_bp.route('/co_op/') | ||
| def display_conditionals(): |
There was a problem hiding this comment.
I totally didn't copy and paste that... 😜 haha
conditional/blueprints/co_op.py
Outdated
|
|
||
|
|
||
| @co_op_bp.route('/co_op/submit', methods=['POST']) | ||
| def submit_major_project(): |
mbillow
force-pushed
the
co-op
branch
2 times, most recently
from
6faf36d to
3028102
Compare
conditional/util/member.py
Outdated
| voting_list = [uid for uid in [member.uid for member in ldap_get_active_members()] | ||
| if uid not in [member.uid for member in ldap_get_intro_members()]] | ||
| if uid not in [member.uid for member in ldap_get_intro_members()] and | ||
| uid not in [member.uid for member in CurrentCoops.query.filter( |
There was a problem hiding this comment.
I think this would be a good place for us to use a filter and a lambda function.
Something where we get the relevant lists before and then just do a quick comparator seems more elegant.
conditional/blueprints/co_op.py
Outdated
| db.session.commit() | ||
|
|
||
| return jsonify({"success": True}), 200 | ||
|
|
There was a problem hiding this comment.
Github is reporting no newline at the end of the file.
There was a problem hiding this comment.
Line 55 looks a lot like a newline to me. Also it passed that portion of the linter.
There was a problem hiding this comment.
It's because you have trailing whitespace there. So it's not just a '\n'
There was a problem hiding this comment.
The amount of effort I just put into convincing my IDE that there was whitespace there was a little asinine. Should be all good now.
conditional/templates/co_op.html
Outdated
| <input type="submit" role="button" class="btn btn-raised btn-primary" style="width:100%;" value="Submit Form"/> | ||
| </form> | ||
| {% else %} | ||
| <p class="align-center">Thanks for submitting this form. Good luck on your {{on_coop.semester}} co-op!</p> |
There was a problem hiding this comment.
Plans change; we should allow people to change their co-op report (up to a certain cutoff perhaps? would be a simple date comparison)
There was a problem hiding this comment.
I am fine with changing it up to a certain point. What I was trying to avoid with this was people having the ability to go on hour long "co-ops" during house meetings.
I will spend some time (probably later today) fleshing out the best way to do this. If you have ideas, feel free to pass them on.
There was a problem hiding this comment.
Ah, yep, that's definitely a valid concern. In that case we could define self-service windows that would only allow changes outside of when school is in session.
There was a problem hiding this comment.
The more that I think about it, the more I am in favor of keeping it like it is. We can add a table to member management for listing who is on co-op and the evals director can just clear it if a mistake was made.
There was a problem hiding this comment.
Added better language to point those whose need to change their submission towards the Evals Director.
| CurrentCoops.date_created > start_of_year(), | ||
| CurrentCoops.semester == semester).all()) | ||
|
|
||
| voting_list = list(active_members - intro_members - on_coop) |
There was a problem hiding this comment.
Huh I didn't realize you could do that with lists in python, weird.
|
|
Add a page where user's can report their co-op block. This then properly updates voting counts and attendance for house meeting.
Fixes #80