Skip to content

Don't Remove Eval Director from Active Group #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Don't Remove Eval Director from Active Group #148

merged 1 commit into from
Jul 25, 2017

Conversation

mbillow
Copy link
Member

@mbillow mbillow commented Jul 25, 2017

We can't have empty groups and the ED should always be active during the transition.

@mbillow mbillow added the bug label Jul 25, 2017
@mbillow mbillow self-assigned this Jul 25, 2017
@liam-middlebrook
Copy link
Member

Lgtm ship after CI

@mbillow
Copy link
Member Author

mbillow commented Jul 25, 2017

In the name of Jordan of the House Rodgers, the First of his Name, King of the Andals and the Rhoynar and the First Men, Lord of the Computer Science House and Protector of the Realm, by the commit of Marc of the House Billow, Warden of Conditional, I do pronounce this PR to be hotfix version 1.5.0a.

@mbillow mbillow merged commit e375f4e into master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants