Conditional 1.6.1 #165
Merged
Conditional 1.6.1 #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like a new version of Pylint is introducing more checks and causing the build to fail. None of the build errors are in files I changed. |
liam-middlebrook
requested changes
Dec 21, 2017
There was a problem hiding this comment.
Shouldn't this be titled as a version bump? (Did you mean to push this to develop and then have the PR be cutting a release?)
If this is supposed to be a version bump I think you should add an additional commit fixing the pylint errors that were caused by what appears to be new pylint settings. Or just set the version of pylint in requirements.txt to what ran before these issues appeared.
|
Yes, it should have been, my bad. Upgraded to the latest PyLint version and fixed the problems it found. CI passes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the words of Emeril Lagasse, BAM!
(Fixes #164)