Add standard icon spacing for all icons #65
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sets a standard distance for all icon spacing * Uses em so that it scales proportionally to font size
Member
|
Hot. 🔥 |
Collaborator
|
@sman591 Looks great, although I think this would be more appropriate as an addition to csh-material-bootstrap. I'm trying to keep all style changes like this in the library so everything looks consistent across apps. If you could make this change over there, preferably as default behavior for glyphicons in navbars, that would be very much appreciated. |
Member
Author
|
@stevenmirabito Sure thing. I'll update this PR once I've added it there. |
Collaborator
|
Closing as this has been added to csh-material-bootstrap and will be added to this project pending the release of v1.0.1 of that library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use this in all my projects as I think icons look a ton better when they're not up right against the text. Adding a space only does so much, and spaces can't stack to increase the distance.
I couldn't get a local environment working so I couldn't fully test this locally, but applying my changes in the web inspector looks like this:
Before:
After:
