Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with cli - deposit #283

Closed
englishcoder opened this issue Feb 24, 2022 · 3 comments
Closed

Issue with cli - deposit #283

englishcoder opened this issue Feb 24, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@englishcoder
Copy link

Command:
deposit is not returning correct amount for what was deposited and either y/n answer is giving "Unknown command:"


Issue:
Scenario A) 1 month, 1 CCX
[wallet ccx7Np]: deposit 1 1
Confirm deposit details:
Amount: 1000000
Months: 1
Intrest: 2416
Create deposit? (y/n)

[wallet ccx7Np]: deposit 1 2
Confirm deposit details:
Amount: 2000000
Months: 1
Intrest: 4833
Create deposit? (y/n)

Scenario B) Tried with decimal 1 month, 1 CCX
[wallet ccx7Np]: deposit 1 1.0
Error: bad lexical cast: source type value could not be interpreted as target


OS: Microsoft Windows [Version 10.0.19044.1526]
Version Tested: https://github.com/ConcealNetwork/conceal-core/actions/runs/1877708559 (ccx-cli-windows-dev-519e1ee)

Additional information:
[wallet ccx7Np]: balance
available balance: 10.671000

Minor note: "Intrest" spelling in response to deposit

@krypt0x krypt0x added the bug Something isn't working label Feb 27, 2022
@cartoon-face
Copy link
Contributor

cartoon-face commented Mar 7, 2022

Just a quick update to this issue:
AxVultis and yourself, englishcoder, have been testing the pull request for this open ticket (#281)

deposit <months> <amount> now works, thank you both for the rigorous testing

@cartoon-face
Copy link
Contributor

@krypt0x I think this ticket can be closed now.

deposit <months> <amount> works as it should and also the spelling has been fixed since.

@krypt0x
Copy link
Member

krypt0x commented Mar 30, 2022

Great job! Thank you

@krypt0x krypt0x closed this as completed Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants