Banking features to concealwallet
#281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same logic as list_transfers
90s error, flashbacks
Return false instead of breaking Fix spelling
Ive been sus of tests for a while now, thinking one every X times during tests it fails
Im absolutly sure that `confirm_deposit()` works as intended This follows the same logic as the tests (TestWalletLegacy.cpp)
Maybe we should make this universal across Deposit and WalletLegacyTransaction
while(true) with a return true statement? Just to be on the safe side
Old output used to have a header to list each detail, now the output will list:
```
--- Deposit Info ---
ID: <deposit_id>
Amount: <amount>
Interest: <interest>
Term: <term>
Status: <is_locked_bool>
Unlock Height: <unlock_height>
```
deposit details will either be `BRIGHT_RED` if locked or `BRIGHT_GREEN` if unlocked
Works on my machine
Fixes calling `cn::Deposit::unlockHeight` + `cn::Deposit::height`
* adds new file DepositHelper to feed infomation * adds get_deposit(id) to iwalletlegacy so we can call deposit = get_deposit(id) * add height and unlockheight to legacydeposit * add notes to previous work
Adds saveDeposits and loadDeposits to wallet serializer. This copies wallet serializer v2 with slight modifications
|
Great job! We'll do a full review and merge it ASAP. Thank you. |
This was apart of testing during the PR and it's safe to say we don't need this.
|
I've updated the description for this again, it should cover everything I've done. I've written user notes and dev notes as well as what's new after testing. Sorry this took so long, we've done some great work here and thank you those who tested this throughout the development. |
* removes unused function from namespace
With the new changes, the height would only of been imported from `concealwallet`s deposit request. This keeps support for the GUI, `if t_height == 0` it hasn't came from simplewallet
* this was suggested by Ax, it seems to work as an alternative serialise new data * also removes table format from balance
|
Hi guys, is there any update on this PR? ETA? |
* this was taken from Ax's suggestion within the discord * makes use of `splitUrlToHostAndUri()`
Reverted back to original state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New commands
deposit <months> <amount>- Creates a HLTC by depositing $CCXwithdraw <deposit_id>- Withdraws banked $CCXlist_deposits- Lists all known deposits in this walletdeposit_info <deposit_id>- Get information for specific depositNotes
User Notes
deposit <months> <amount>+withdraw <deposit_id>will always use the minimum fee in the network consensus, currently set to0.001 $CCX.<deposit_id>can be found via thelist_depositscommand.<deposit_id>is used forwithdraw <deposit_id>anddeposit_info <deposit_id>."Please wait."in the"Unlock Height"field.Dev Notes
deposit()might look like it belongs to theTransferCommandstruct but as only 2 args are needed (term + amount), with none being optional, we don't use this struct, assign the args and use them as is.std::vector<DepositID>, onlyDepositIDused inconcealwallet'swithdrawcommand.cn::Deposit::height. Now it uses data from deposit requests using the current node height to provide the output.cn::Deposit::unlockHeight. Previously, this would only return the term of the deposit because height would return0. Now that height is fixed, that means this has also been fixed.What's New After Testing?
list_depositslist_depositsto matchlist_transfersdeposit <months> <amount>command, the client will ask you to confirm the details showing you the information for the deposit that is about to be processed. User can pressYorNto confirm or decline the deposit.balancewill now also show your deposited balances (actual & locked).