Conceal Core v6.6.0 #261
Merged
Conceal Core v6.6.0 #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryptoNote = cn Crypto = crypto
Common = common Logging = logging TransactionTypes = transactions_types
Base58 = base_58 Base64 = base_64
Console = console System = platform_system
Revert Miner = miner, see #248 (review)
I don't know whether to keep the Miner directory within CMakeLists, I added it to see if the compiler would start spitting errors out relating to that but there's no apparent changes happening. Miner class was mixed up with Miner namespace
Full namespace changes
Namespaces changes
Namespace names should comply with a naming convention. Renaming all `namespace` ocurrences to match the regular expression: `^[a-z][a-z_0-9]*$` https://www.tutorialspoint.com/cplusplus/cpp_namespaces.htm
Run test in GitHub Actions
Update build instructions
Mixins changed to 5. Ringsize = Mixins + 1 = 6
fix typo in ConnectivityTool.cpp
Fix Payment Service Ringsize
These both are unused
Enforce default mixin usage
Remove standalone miner + connectivity tool
reduce string limits to a sane value
reduce string value limit
Split arm part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conceal Core v6.6.0 - "Ataegina"