Save all transactions to file #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxVultis
requested changes
Jul 12, 2022
* dont use .erase() as this will rename m_wallet_file * new private member to store formatted wallet name * add logger so user can see progress * update notes * remove is_minus variable
* redo m_frmt_wallet_file to take data from temp string * update command to include deposits too * make command optional bool where false is default
* fix "ext_help" output for new command * remove todo note in new command * use correct variables in both for statements * add height column in deposit output * new list deposit as string function * fix output to align * TODO add "list_deposit_item()" to DepositHelper.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will need a quick test