Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Updated Dependencies & Other Stuff #302

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

notdixon
Copy link
Contributor

@notdixon notdixon commented Aug 8, 2022

Removed redundant dependencies

Both GCC and G++ are included with the build-essential package, so including them in the dependency list (ie apt install .....) is redundant.

Changed 'python-dev' to 'python3-dev'

On Ubuntu and Debian Based Systems, python refers to Python 2, and the package that is actually needed is named python3-dev. Attempting to install python-dev threw this error on Linux Mint 21:

Package python-dev is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
However the following packages replace it:
 python2-dev:i386 python2:i386 python2-dev python2 python-dev-is-python3

E: Package 'python-dev' has no installation candidate

Changed 'Ubuntu' to 'Linux'

Changed the header of 'Building/Ubuntu' to 'Building/Linux', as the commands there are pretty much identical across all distributions, so instead of it saying:

On Ubuntu:

It now says

On Linux Systems:

apt-get is now apt

Changed apt-get install to apt install. Functions pretty much the same as apt-get install

--> Removed redundant dependencies
'gcc' and 'g++' are included in the 'build-essential' package, so also
listing them to be installed is redundant.

--> Changed 'python-dev' to 'python3-dev'
On Ubuntu and Debian Based Systems, 'python' refers to Python 2, and the
package that is actually needed is named 'python3-dev'

--> Changed 'Ubuntu' to 'Linux'
Changed the header of 'Building/Ubuntu' to 'Building/Linux', as the
commands there are pretty much identical across all distributions.

--> 'apt-get' is now 'apt'
In the dependencies, removed '-get' from 'apt-get install', as it's not
required, 'apt' works, and most people are just going to use plain 'apt'
@AxVultis AxVultis changed the base branch from master to development August 10, 2022 20:13
Copy link
Member

@AxVultis AxVultis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AxVultis AxVultis merged commit a39938f into ConcealNetwork:development Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants