Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove anon word #369

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Remove anon word #369

merged 7 commits into from
Jun 18, 2024

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Jun 6, 2024 •
edited
Loading

Purpose

addresses #364

Changes

  • Remove shielded button.
  • Remove encryptedTransfer button.
  • Rename anonymity revokers to identity disclosure authorities.

@DOBEN DOBEN requested review from soerenbf and limemloh June 10, 2024 18:42
soerenbf
soerenbf reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick search, and in app/components/ledger/CredentialInfoLedgerDetails it states "Anonymity revocation threshold". Did we not agree to change this? I remember a discussion on AR => "authorities required", but maybe this was not approved?

app/pages/Accounts/AccountViewActions/AccountViewActions.tsx Outdated Show resolved Hide resolved
@DOBEN DOBEN merged commit 2a5af63 into main Jun 18, 2024
4 checks passed
@DOBEN DOBEN deleted the remove-anon-word branch June 18, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soerenbf soerenbf soerenbf approved these changes

@limemloh limemloh limemloh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DOBEN @soerenbf @limemloh