Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code and broken tests and fixes #136

Merged
merged 7 commits into from
Feb 17, 2023

Conversation

shjortConcordium
Copy link
Contributor

@shjortConcordium shjortConcordium commented Feb 16, 2023

Purpose

Cleanup repository

Changes

  • Removed unused code from deserializationHelpers
  • Removed deserializeSchema / getContractSchema (Not exported from index and unused)
  • Removed tests for removed code.
  • Removed broken tests related to old testnet / GRPC v1 client.
  • Removed disabling wasm-opt on release builds. (It was added due to a bug, I believe this is the relevant issue wasm-opt: Exported global cannot be mutable rustwasm/wasm-pack#886)
  • Fix broken serialization in get_credential_deployment_details_aux.
  • Added build:dev option to quickly build without wasm-opt / regenerating the grpc api.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link
Collaborator

@rasmus-kirk rasmus-kirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shjortConcordium shjortConcordium merged commit a98c356 into main Feb 17, 2023
@shjortConcordium shjortConcordium deleted the remove-unused-code branch February 17, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants