Update release instructions #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renamed generated swift file to avoid it being confused for manual work by reviewers.
bisgardo
changed the title
bisgardo
commented
Apr 17, 2024
soerenbf
approved these changes
Apr 25, 2024
Merged
bisgardo
added a commit
that referenced
this pull request
Apr 25, 2024
Bump the version of the Cargo project, regenerate Swift bindings, and update the package spec to point to the binary framework built from the updated Cargo project. This follows the release process described [here](https://github.com/Concordium/concordium-wallet-crypto-swift/blob/13dd10cd4711e9ee77d57a9099d9b37001456afe/README.md#release-new-version). The `.gitignore` rule for `generated.swift` introduced in #12 had no effect because the file is tracked, so it was removed again. A suggestion to employ a local alternative was added to the doc instead.
Merged
bisgardo
added a commit
that referenced
this pull request
Apr 26, 2024
The workflow (added in #12) erronously uses `github.ref` as the version name, but that value includes a `ref/tags/` prefix that should be removed. Added a step for doing that and ensured that the correct value is used. Also needed to add submodule checkout for `cargo metadata` to work as well as throwing away logging output on stderr. It was expected that there could be issues with this workflow becuse it couldn't be tested in advance. It's better tested now, but we still need a full successful run on `main` to be sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made release instructions clearer and change the "release" tag to happen after the release PR has been merged to
main. This (along with the following) ensures that this PR isn't included in the release notes of the next framework release.Added a workflow to publish a release on tags of the form
x.y.z(i.e. for release of the Swift package). This means that we'll have releases both when we publish framework and package (the former now has "(framework)" appended to its release name). This workflow cannot be tested before it's been merged tomain, but aworkflow_dispatchtrigger has been added in case we need to debug.The old releases have already been updated to conform to the changes in this PR.
The indentation in the workflow files has been adjusted for consistency.
In the "Publish Binary Framework" workflow the
zipcommand was replaced withdittoas that is recommended in various places because it's the command that Finder uses to compress. It apparently also includes things thatzipdoesn't which could be relevant if the contents were to be signed at some point...Finally, the generated swift file was also renamed to
generated.swiftto prevent it from confusing reviewers to think that it's manual work 🙈