Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtering on accTransactions. #122

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix filtering on accTransactions. #122

merged 1 commit into from
Jan 29, 2025

Conversation

td202
Copy link
Contributor

@td202 td202 commented Jan 28, 2025

Purpose

Addresses #121

This corrects the filtering that was intended to exclude the ValidatorSuspended and ValidatorPrimedForSuspension events from the v0 and v1 versions of the accTransactions endpoint, but also excluded all regular transaction events.

Changes

  • Revise the WHERE clause to behave correctly. In particular, allow the case where the tag is NULL.
  • Bump version.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@td202 td202 merged commit 2c3be8c into main Jan 29, 2025
2 checks passed
@td202 td202 deleted the fix-acc-transactions branch January 29, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants