Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol 7 changes #1060

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Protocol 7 changes #1060

merged 2 commits into from
Sep 27, 2024

Conversation

TinaKT
Copy link
Contributor

@TinaKT TinaKT commented Sep 20, 2024

Changes in documentation resulting from Protocol 7.

Please review.

@TinaKT TinaKT requested a review from td202 September 20, 2024 09:44
Copy link
Contributor

@td202 td202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I guess we should probably hold off deploying this until P7 is live on mainnet, to avoid misleading people.

I also wonder if it would be useful to just have a note somewhere acknowledging the change in behaviour from the previous protocol version. Something along the lines:

  • In P6, when you reduce or remove your stake, the effect of the change is delayed for the cooldown period. You can't make other changes to the stake while this change is pending. The stake is still active in this period and cannot be spent.
  • In P7, when you reduce or remove your stake, it immediately goes into an inactive cooldown state, where it cannot be spent, but won't count as active stake (e.g. for rewards). The stake in cooldown will be available to spend after the cooldown period elapses.

@TinaKT
Copy link
Contributor Author

TinaKT commented Sep 22, 2024

Looks good. I guess we should probably hold off deploying this until P7 is live on mainnet, to avoid misleading people.

I also wonder if it would be useful to just have a note somewhere acknowledging the change in behaviour from the previous protocol version. Something along the lines:

  • In P6, when you reduce or remove your stake, the effect of the change is delayed for the cooldown period. You can't make other changes to the stake while this change is pending. The stake is still active in this period and cannot be spent.
  • In P7, when you reduce or remove your stake, it immediately goes into an inactive cooldown state, where it cannot be spent, but won't count as active stake (e.g. for rewards). The stake in cooldown will be available to spend after the cooldown period elapses.

I have added a note about this to the page "Delegation and validation FAQ" (delegation-faq.rst)

@TinaKT TinaKT merged commit 2ec20c8 into main Sep 27, 2024
2 checks passed
@TinaKT TinaKT deleted the protocol-7 branch September 27, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants