Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm@5 package-lock.json artifact #69

Merged
merged 4 commits into from
Jun 27, 2017
Merged

Add npm@5 package-lock.json artifact #69

merged 4 commits into from
Jun 27, 2017

Conversation

crccheck
Copy link
Contributor

@crccheck crccheck commented Jun 26, 2017

Why are we doing this?

This adds Npm v5's package-lock.json. It also updates some dependencies. Eventually, someone else will be running Npm v5 and will generate this file too, so I'm committing it now for the future.

Did you document your work?

N/A

How can someone test these changes?

Steps to manually verify the change:

  1. npm i
  2. npm t

What possible risks or adverse effects are there?

  • As usually, some dep update may break something, but no major prod dep versions were upgraded.
  • The package-lock.json throws off github line diff counts, so they no longer mean anything.

What are the follow-up tasks?

none

Are there any known issues?

none

Did the test coverage decrease?

none, keeps the project up to date.

@crccheck crccheck requested a review from stripethree June 26, 2017 17:00
@@ -55,12 +55,12 @@ class Messenger extends EventEmitter {
/*:: options: Object */
/*:: pages: Object */
constructor({
hookPath = '/webhook',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They changed the indention rules in Eslint v4 http://eslint.org/docs/user-guide/migrating-to-4.0.0

I don't really like them, but if that's what JavaScript is doing 🤷‍♂️ I'll live with it

@stripethree
Copy link
Contributor

Would it be useful to add a link or some documentation in the summary for future developers on how package-lock.json gets updated?

@crccheck
Copy link
Contributor Author

When you use npm, it says:

npm notice created a lockfile as package-lock.json. You should commit this file.

I think that's enough documentation.

@crccheck crccheck merged commit 973b4e9 into master Jun 27, 2017
@crccheck crccheck deleted the npm5 branch June 27, 2017 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants