Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
We made a way to do Image + quick replies but not Text + quick replies. This adds that missing message type, it also deprecates the old
ImageQuickReply
helper in favor of plainText
andImage
+.quickReplies()
method. Adding quick replies isn't really a new message type, it's a modification of existing types. The syntax from the tests and README look like:closes #60
Did you document your work?
README is updated. I wonder if this should move to the wiki though, the README is getting heavy.
How can someone test these changes?
Steps to manually verify the change:
npm i
npm t
What possible risks or adverse effects are there?
tech debt increases slightly but can improve when
ImageQuickReply
is removed. There's also some potential for a DRY refactorWhat are the follow-up tasks?
Are there any known issues?
none
Did the test coverage decrease?
new code is covered, increasing coverage