-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle a wider variety of messages more gracefully #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crccheck
changed the title
WIP Handle a wide variety of messages more gracefully
Handle a wider variety of messages more gracefully
Oct 26, 2017
Ok, did some cleanup so ready for review now |
stripethree
approved these changes
Oct 27, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm i
✅
npm t
✅
Nice work on the test cleanup, coverage, and migration to supertest
!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
Facebook uses webhooks not only for Messenger, but for all sorts of events. Currently, if a request comes into the bot and it's not a Messenger event, it'll throw an error. Instead of throwing an error, it should just ignore non Messenger events.
closes #73
Did you document your work?
none necessary, internal changes
How can someone test these changes?
Steps to manually verify the change:
npm install
npm test
You can also
npm link
this to an existing botWhat possible risks or adverse effects are there?
What are the follow-up tasks?
Are there any known issues?
The Conversation logger could use more robust logic, but skipping that for now because "Slack ghost" might be better approach for logging to Slack.
Did the test coverage decrease?
increases. Some old code is now covered, tests reorganized a bit.