Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jest config to pick test files in node_modules #5

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

gautamarora
Copy link
Contributor

@gautamarora gautamarora commented Jun 5, 2018

Fixes #4

Description

As identified by @pgoldrbx the issue was with Haste ignoring any code in node_modules.
This issue has been extensively discussed here and a fix is to update the jest config for haste to allow all dirs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

#4

Motivation and Context

The tool doesnt work as a command line utility without this fix :)

How Has This Been Tested?

Manually tested for a few projects.

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

@pgoldrbx pgoldrbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

roots: ["src"]
roots: ["src"],
haste: {
"providesModuleNodeModules": [".*"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhhhhhh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gautamarora gautamarora merged commit aaa7a69 into master Jun 5, 2018
@gautamarora gautamarora deleted the fix/global-module-issue branch June 5, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use when installed globally
3 participants