fix(run): handle version strings aren't strictly semver #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garryyao
force-pushed
the
fix/semver-pre-release
branch
from
b98d768
to
8d2e033
Compare
garryyao
force-pushed
the
fix/semver-pre-release
branch
from
8d2e033
to
788e6b4
Compare
garryyao
commented
Jan 5, 2024
| let from = matches[2]; | ||
| let to = matches[3]; | ||
| let from = coerce(matches[2]); | ||
| let to = coerce(matches[3]); |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles version strings in PR title that does not strictly conforms to semver and by coerce them into semver before comparing the two versions eliminates e.g. the following error we have seen from some repos: