Added function to allow dot notation in Source->config array #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrands02
reviewed
Oct 8, 2024
| { | ||
|
|
||
| if(($diff = array_diff(self::REQUIRED_PARAMETERS_PASSWORD, array_keys(array: $configuration))) !== []) { | ||
| throw new BadRequestException(message: 'Some required parameters are not set: ['.implode(separator: ',', array: $diff).']'); |
There was a problem hiding this comment.
Can the implode be assigned to a var on an empty line above?
bbrands02
reviewed
Oct 8, 2024
| @@ -3,9 +3,138 @@ | |||
| namespace OCA\OpenConnector\Service; | |||
|
|
|||
|
|
|||
| use GuzzleHttp\Client; | |||
| use OAuthException; | |||
| use Symfony\Component\HttpFoundation\Exception\BadRequestException; | |||
|
|
|||
| class AuthenticationService | |||
There was a problem hiding this comment.
Do we want class docblocks in this repo?
There was a problem hiding this comment.
There was no docblock yet, we can add it if we want to.
There was a problem hiding this comment.
This is not a question, we want docblocks
rjzondervan
reviewed
Oct 8, 2024
Comment on lines
+186
to
+198
| // Check if there are keys containing a dot we want to map to a different position in the $config array. | ||
| foreach ($config as $key => $value) { | ||
| if (str_contains($key, '.')) { | ||
| $dotConfig->set($key, $value); | ||
| $unsetKeys[] = $key; | ||
| } | ||
| } | ||
|
|
||
| // Remove the old keys containing a dot that we mapped to a different position in the $config array. | ||
| $config = $dotConfig->all(); | ||
| foreach ($unsetKeys as $key) { | ||
| unset($config[$key]); | ||
| } |
There was a problem hiding this comment.
For my understanding, this is to prevent a key that contains a dot from being seen as another step deeper in the dotArray?
There was a problem hiding this comment.
To remove these:
Otherwise they would still be present here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.