Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement granting and revoking of user roles #4

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Implement granting and revoking of user roles #4

merged 7 commits into from
Aug 28, 2023

Conversation

martinalbert
Copy link
Contributor

@martinalbert martinalbert commented Aug 10, 2023 •
edited
Loading

Implements granting and revoking of user roles.

Resolves https://github.com/ConductorOne/baton-project-status/issues/48.

Limitations

  • User always have to contain a role, so revoke method will set the user role to default role - member

jakcinmarina
jakcinmarina suggested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@jakcinmarina jakcinmarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fix the build step in makefile and it's OK

@martinalbert martinalbert merged commit 7703720 into main Aug 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakcinmarina jakcinmarina jakcinmarina approved these changes

@jirwin jirwin Awaiting requested review from jirwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinalbert @jakcinmarina