New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CrowdStrike SDK #7

Closed

pquerna wants to merge 2 commits into main from pq/update_deps_feb_2024

pquerna commented Feb 17, 2024

In SDK version 0.5.0, upstream broke the ABI for DomainUser; Good news is we now can get .Email directly!

pquerna added 2 commits

February 17, 2024 04:43


Rebuild vendor

834a787


Updates for upstream API changes; Domain User now has an email field.

9e6b205

pquerna requested a review from martinalbert

February 17, 2024 04:45

Contributor

martinalbert commented Feb 20, 2024

@pquerna seems ok, but I tested this and found that even previous update of falcon library is incorrectly mapping the user. 😕

Looking through the library they changed the tags, but not everywhere, so might be bug.

creating user with old tags: https://github.com/CrowdStrike/gofalcon/blob/main/falcon/models/domain_create_user_request.go
getting user with new probably invalid tags: https://github.com/CrowdStrike/gofalcon/blob/main/falcon/models/domain_user.go

Contributor

ggreer commented May 24, 2024

#9 uses an even newer version of the crowdstrike SDK and fixes lots of issues with syncing users. We still need to add email though: https://github.com/ConductorOne/baton-crowdstrike/pull/9/files#diff-45177d2a0e67a8fa3b9e5cd9c4e7f6030ce4a15510849b518404b2738296f36aR59

ggreer closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment